PHP Warning, non numeric value

+++ b/src/Plugin/EntityBrowser/Display/Modal.php
@@ -108,6 +108,10 @@ class Modal extends IFrame {
+      $this->configuration['height'] - 90;

This does nothing, Did you mean $height = $this->configuration['height'] - 90?

Configuration form only allowed numerical values for width/height so the configuration value that is causing problems probably comes from some other source. Could you share the config yaml of the entity browser that is causing problems?

Since #2684989: Entity Browser Responsive Modal Dialog you can actually leave the height and width configuration empty, which will lead to '' (an empty string) being saved as the configuration value. The configuration schema for height and width also uses string as its type. In this case PHP then yields the error mentioned above, when doing '' - 90.

With attached patch, I solve the warning

The patch in #8 cannot work for the error I have, which is on line 119, and the patch comes later in the code.

This is much simpler and has fixed the issue for me.

@glass.dimly: I don't think it is a good idea, because if the height is not filled in in configuration, the height attribute will be negative

@SylvainM -- similarly, for #8, it needs a check that $this->configuration['height'] is not less than 90 ;)
Otherwise, #8 LGTM

Damned! ;-)

This is fixed with attached patch.
I added another check (is_numeric) because someone could try with percentages

Patch #12 LGTM.

Works as advertised.

Fixed formatting as per https://www.drupal.org/docs/develop/standards/coding-standards#linelength

Test fails are not related, will fix them in a separate issue. Committed.