I think, that the entity browser is a key feature for entity reference selection. Especially as soon as we can handle views, it will be crucial to have a responsive dynamic modal. The fixed width / height are quite limiting.

I created a patch to allow the possibility to have empty width / height. The resulting modal will be responsive including the content in the iframe.

Modal dialog

I created a pull request on github.com. Attached you find the patch file.
https://github.com/drupal-media/entity_browser/pull/144

CommentFileSizeAuthor
#11 interdiff.txt5.16 KBslashrsm
#11 2684989_11.patch4.88 KBslashrsm
#7 144-2.diff4.81 KBayalon
#4 Izbor_008.png56.18 KBslashrsm
#3 modal.png27.86 KBayalon
#3 144.diff.txt4.01 KBayalon
144.diff.txt4.01 KBayalon
modal.png27.14 KBayalon

Comments

ayalon created an issue. See original summary.

ayalon’s picture

ayalon commented
Issue summary: View changes
ayalon’s picture

ayalon commented
Issue summary: View changes
StatusFileSize
new 144.diff.txt4.01 KB
new modal.png27.86 KB
slashrsm’s picture

slashrsm commented
Issue summary: View changes
Status: Active » Needs work
Issue tags: +Media Initiative, +D8Media
StatusFileSize
new Izbor_008.png56.18 KB

Thank you for contributing. This will be a great improvement. I tested this with entity_browser_example and it behaves strange. Modal becomes very small which makes it's content impossible to see. See attached image:

Branch needs rebase and squash of commits. Left few nitpik comments on the pull request.

ayalon’s picture

ayalon commented

I will install it with entity example too see if I can reproduce the behaviour.

ayalon’s picture

ayalon commented

@slashrsm: I tested my patch with the entity browser example module and it works flawlessly. There must be another problem. Against which version did you apply the patch? Did you clear the cache and the browser cache to get the updated js file?

ayalon’s picture

ayalon commented
StatusFileSize
new 144-2.diff4.81 KB

I did some improvements according to scrolling and minor fixes according to the notes on github. I tested the patch against the latest dev in several browsers.

ayalon’s picture

ayalon commented
Status: Needs work » Needs review

Can anyone give some feedback on this?

Status: Needs review » Needs work

The last submitted patch, 7: 144-2.diff, failed testing.

ayalon’s picture

ayalon commented
Status: Needs work » Reviewed & tested by the community

This was tested and reviewed by https://github.com/jhedstrom

See here:
https://github.com/drupal-media/entity_browser/pull/144

Its a pity, this still is not merged. Even though its a cool feature and a lot of time went into it.

slashrsm’s picture

slashrsm commented
StatusFileSize
new 2684989_11.patch4.88 KB
new interdiff.txt5.16 KB

Fixed some coding standard/eslint problems.

slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • slashrsm committed 3bef66d on 8.x-1.x authored by ayalon 
    Issue #2684989 by ayalon, slashrsm, jhedstrom: Entity Browser Responsive...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.