Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff.txt | 746 bytes | slashrsm |
#17 | 2851512_17.patch | 906 bytes | slashrsm |
#12 | entity_browser-fix_warning_none_numeric_-value-2851512-12.patch | 979 bytes | SylvainM |
#9 | entity_browser-1943336-php_warning_non_numeric_value.patch | 625 bytes | glass.dimly |
#8 | entity_browser-fix_warning_none_numeric_-value-2851512-8.patch | 866 bytes | SylvainM |
Comments
Comment #2
Erik Seifert CreditAttribution: Erik Seifert commentedComment #3
zerolab CreditAttribution: zerolab at Torchbox commentedThis does nothing, Did you mean
$height = $this->configuration['height'] - 90
?Comment #4
Erik Seifert CreditAttribution: Erik Seifert commentedUpdated patch file.
Comment #5
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedConfiguration form only allowed numerical values for width/height so the configuration value that is causing problems probably comes from some other source. Could you share the config yaml of the entity browser that is causing problems?
Comment #6
Erik Seifert CreditAttribution: Erik Seifert commentedIt seems to be form an older version of entity browser allowed non numeric values. So we had non numeric values in our feature export. Could be closed.
Comment #7
tstoecklerSince #2684989: Entity Browser Responsive Modal Dialog you can actually leave the height and width configuration empty, which will lead to
''
(an empty string) being saved as the configuration value. The configuration schema for height and width also usesstring
as its type. In this case PHP then yields the error mentioned above, when doing'' - 90
.Comment #8
SylvainM CreditAttribution: SylvainM at Axess Open Web Services commentedWith attached patch, I solve the warning
Comment #9
glass.dimly CreditAttribution: glass.dimly commentedThe patch in #8 cannot work for the error I have, which is on line 119, and the patch comes later in the code.
This is much simpler and has fixed the issue for me.
Comment #10
SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented@glass.dimly: I don't think it is a good idea, because if the height is not filled in in configuration, the height attribute will be negative
Comment #11
zerolab CreditAttribution: zerolab at Torchbox for The Chartered Society of Physiotherapy commented@SylvainM -- similarly, for #8, it needs a check that
$this->configuration['height']
is not less than 90 ;)Otherwise, #8 LGTM
Comment #12
SylvainM CreditAttribution: SylvainM at Axess Open Web Services commentedDamned! ;-)
This is fixed with attached patch.
I added another check (is_numeric) because someone could try with percentages
Comment #13
SylvainM CreditAttribution: SylvainM at Axess Open Web Services commentedComment #14
Brian-C CreditAttribution: Brian-C at American Medical Association commentedPatch #12 LGTM.
Comment #15
sam.spinoy@gmail.com CreditAttribution: sam.spinoy@gmail.com at Adapt commentedTested patch #12, works fine, allows me to add images to nodes again.
Comment #16
mErilainen CreditAttribution: mErilainen at Wunder commentedWorks as advertised.
Comment #17
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedFixed formatting as per https://www.drupal.org/docs/develop/standards/coding-standards#linelength
Comment #20
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedTest fails are not related, will fix them in a separate issue. Committed.