Social Auth Twitter allows users to register and login to a Drupal site with their Twitteraccount. It is based on Social Auth and Social API. This module adds a path user/login/twitter which redirects the user to Twitter Accounts for authentication.

Login process can be initiated from the "Twitter" button in the Social Auth block. Alternatively, site builders can place (and theme) a link to user/login/twitter wherever on the site.

Site administrators can configure their Consumer Key and Consumer Secret in the settings form

There is an installation guide at https://www.drupal.org/node/2841605

Link to project sandbox: https://www.drupal.org/sandbox/utkarsh-dixit/2841076

Clone URL::
git clone --branch 8.x-1.x https://git.drupal.org/sandbox/utkarsh-dixit/2841076.git social_auth_twitter

PA Reviews
https://www.drupal.org/node/2850757#comment-11923479
https://www.drupal.org/node/2851052#comment-11927262
https://www.drupal.org/node/2851348#comment-11927021

CommentFileSizeAuthor
#8 remove_unsed_variable-2841076.patch480 bytesaloknarwaria
settings_form.png41.37 KBdenutkarsh
social_auth_block.png4.51 KBdenutkarsh

Comments

denutkarsh created an issue. See original summary.

denutkarsh’s picture

denutkarsh commented
Issue summary: View changes
PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

denutkarsh’s picture

denutkarsh commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
denutkarsh’s picture

denutkarsh commented
Priority: Normal » Major
aloknarwaria’s picture

aloknarwaria commented
Status: Needs review » Needs work

Hi @denutkarsh,

Please find my first investigation over your module.

1. After install first time I am getting 500 error page.
PHP Fatal error: Class 'Drupal\\social_auth\\Form\\SocialAuthSettingsForm' not found in /home/d8demo1/web/modules/social_auth_twitter/src/Form/TwitterAuthSettingsForm.php on line 11,

2. You should provide the configuration link in you "social_auth_twitter.info.yml" file.
configure: social_auth_twitter.settings_form

3. I have seen so may error regard the formatting and documentations issue once you fix the above 2 I will share you patch to fix the other issue.

denutkarsh’s picture

denutkarsh commented
Status: Needs work » Needs review

@aloknarwaria Thanks for reviewing this.
1) It needs social_auth and social_api to run. Please install those modules first.
2) I don't really like to provide the configure option in /admin/modules . Anyways my settings are linked with Social Auth Settings.
3) This is not really a application blocker, though i would really appreciate patch for this.

aloknarwaria’s picture

aloknarwaria commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new remove_unsed_variable-2841076.patch480 bytes

Hi @denutkarsh,

Please find the patch to remove the unused variables in your code.

No doubt written code has very good please of work.

Grt work :)

denutkarsh’s picture

denutkarsh commented

@aloknarwaria Created an issue for this, with this patch and also credited you. #2856316: Remove unused variable $client . This issue is fixed now

gvso’s picture

gvso
Primary language Spanish
commented

Module works fine and code looks good to me. RTBC+1

himanshu-dixit’s picture

himanshu-dixit commented

Tested and reviewed the code. This looks good to me . RTBC +1

denutkarsh’s picture

denutkarsh commented
Priority: Major » Critical
visabhishek’s picture

visabhishek commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, Utkarsh Dixit!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

visabhishek’s picture

visabhishek commented

Assigning Credits.

denutkarsh’s picture

denutkarsh commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.