When using latest version of Deploy Version: 7.x-3.0-alpha1 as Editor,
When I browse to Deploy Plan Page: (eg: admin/structure/deploy/plans/list/drupaleditor/view)
It gives list of content present in deploy plan and shows VBO option as 'Remove entity from deployment plan'
and 'Use Latest Revision of Entity'.

If I selects couple of content from deploy plan and Select 'Remove entity from deployment plan' it fails to remove the content from deploy plan and simply throws PHP fatal error
Fatal error: Class name must be a valid object or a string in includes\common.inc on line 8041

CommentFileSizeAuthor
#7 Fix_PHP_error_for_deploy_manager_entities_label-2849317-7.patch1.96 KBdineshw
#5 Fix_PHP_error_for_deploy_manager_entities_label-2849317-4.patch1.96 KBdineshw
#3 Fix_PHP_error_for_deploy_manager_entities_label-2849317-3.patch1.59 KBdineshw
deploy.png7.66 KBdineshw

Comments

dineshw created an issue. See original summary.

dineshw’s picture

dineshw commented
dineshw’s picture

dineshw commented
Status: Active » Needs review
StatusFileSize
new Fix_PHP_error_for_deploy_manager_entities_label-2849317-3.patch1.59 KB

Following patch provides correct entity_type as type property for deploy_manager_entities

Providing $entity->type instead $entity->entity_type helps to get correct labels for entities stored in table deploy_manager_entities

Originally $entity->entity_type used to hold value deploy_manager_entities which does not helps and throws PHP Error when we select 'Remove entity from deployment plan'

I praposed to use method deploy_manager_entities_get_by_id to fetch correct entity_type stored in tabledeploy_manager_entities.

Status: Needs review » Needs work

The last submitted patch, 3: Fix_PHP_error_for_deploy_manager_entities_label-2849317-3.patch, failed testing.

dineshw’s picture

dineshw commented
StatusFileSize
new Fix_PHP_error_for_deploy_manager_entities_label-2849317-4.patch1.96 KB

Revised Patch is here, I'm able to test deletion of entities with this patch.

dineshw’s picture

dineshw commented
dineshw’s picture

dineshw commented
StatusFileSize
new Fix_PHP_error_for_deploy_manager_entities_label-2849317-7.patch1.96 KB

Added revised patch here, I'm able to test deletion of entities with this patch.

dan.munn’s picture

dan.munn commented

Dinesh - as per conversation, the problem you're reporting is when used with personalize_fields as it sets entity_type attribute on the entity when loaded, overwriting any information already present. The conclusion was that the deploy module is operating as it intends, but its behaviour from personalize_fields that should be patched - so not to force entity_type attribute on the entity, but only do so when it does not exist.

I think this otherwise should be closed as its not a bug with deploy, or contrib modules deploy is leveraging directly.

dineshw’s picture

dineshw commented
Status: Needs work » Closed (works as designed)

Closing this bug as highlighted by @dan.munn fix should goes to https://www.drupal.org/node/2849573

Bug exisit only when personalize_fields is enabled. Hence closing this as 'works as designed1'
Thanks For Quick review @dan.munn