[D7] Share Node

Please do not assign ticket yourself. See the workflow https://www.drupal.org/node/532400

Fix the errors reported by pareview
https://pareview.sh/node/839

Will do a manual review soon.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxlcmaquino2844371git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Review of the 7.x-1.x branch (commit 909e6bf):

FILE: /root/repos/pareviewsh/pareview_temp/share_node.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | [x] Equals sign not aligned with surrounding assignments;
| | expected 1 space but found 2 spaces

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Please explain in detail the use of configuration page, as i am not clear what values i can fill in "Public keyword:" and what it is used for. Also i am not clear what is the use of "Field name to use Share node:" when i am adding a field in content type.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

1. (*) The "Public keyword: " i entered in settings page, is reflected in "Share node-Autocomplete username" field, eventhough i don't have any such user on site. Its very confusing.
2. (+) Solve the notice:
   Notice: Undefined property: stdClass::$field_abc in share_node_edit_node_access_callback() (line 259 of /sites/all/modules/contrib/2844371/share_node.module).
3. Remove unnecessary commented out code.
4. To follow consistency in .info file, remove quotes added in core.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Share_node

Manual Review

Individual user account

Yes: Follows

No duplication

No: Causes - some functionality is already provided by content_access module

Master Branch

Yes: Follows

Licensing

No: Does not follow - no licensing information provided

3rd party assets/code

Yes: Follows - no 3rd party assets used

README.txt/README.md

Yes: Follows

Code long/complex enough for review

Yes: Follows

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

Coder Results

1. Missing short description in doc comment
2. PHP version not specified
3. Missing @category tag in file comment
4. Missing @package tag in file comment
5. Missing @author tag in file comment
6. Missing @license tag in file comment
7. Missing @link tag in file comment
8. Doc comment for parameter "$form" missing
9. Doc comment for parameter "$form_state" missing
10. Missing @return tag in function comment
11. Function name "share_node_admin_settings" is prefixed with a package name but does not begin with a capital letter
12. Opening brace should be on a new line
13. Line indented incorrectly
14. Opening parenthesis of a multi-line function call must be the last content on the line
15. Multi-line function call not indented correctly expected 4 spaces but found 2
16. Closing parenthesis of a multi-line function call must be on a line by itself
17. Function name "share_node_admin_settings_validate"" is prefixed with a package name but does not begin with a capital letter
18. Line exceeds 85 characters

Additional Comments

Under settings for Field name to use Share node: this should not be a text field, this should be a select or autocomplete so all the valid options can been seen and avoid annoying error messages like “The field "" was not found. The field bases can be used to generate options

Why do we even need to specify a share field at all? The share feature should be enabled for any node that has a field of type share node

This review uses the Project Application Review Template.

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.