Problem/Motivation

The hooks introduced by the module are redundant as the jobs are implemented as config entities.

Proposed resolution

1. Deprecated the hook invokes -- probably removed in 3.x ?
1. update API documentation.

Remaining tasks

User interface changes

N/A

API changes

Probably as these hooks do not work anymore.

Data model changes

N/A

Original issue summary

There are some hooks defined in ultimate_cron.api.php which don't seem to actually work, specifically:

  • hook_cronapi
  • hook_cron_easy_hooks and hook_cron_easy_hooks_alter
  • hook_pre_invoke
  • hook_post_invoke
  • hook_ultimate_cron_plugin_build_operations
CommentFileSizeAuthor
#8 ultimate-cron.png145.86 KBvijaycs85
#5 2842834-5.patch7.98 KBrgpublic

Issue fork ultimate_cron-2842834

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2660208: Release plan for Ultimate Cron 8.x-2.x

From the POV of API completion, I suggest resolving this for 2.0-beta1.

robin.houtevelts’s picture

robin.houtevelts commented

wtf, been looking at this for way too long.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Most of those hooks don't exist onpurpose and should be removed, cron jobs are defined using in config entities, see #2744129: Document how to create cron jobs.

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented
StatusFileSize
new 2842834-5.patch7.98 KB

Okay, first tentative attempt for a patch to move this issue forward.

simon georges’s picture

simon georges commented
Status: Active » Needs review

Changing status to "Needs review", as there is a patch.

Status: Needs review » Needs work

The last submitted patch, 5: 2842834-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Title: Ensure all documented hooks are actually triggered » Remove unnecessary hooks
Issue summary: View changes
StatusFileSize
new ultimate-cron.png145.86 KB

Most of those hooks don't exist on purpose and should be removed, cron jobs are defined using config entities

If I understand this correctly, the task here is to remove those hooks getting fired (see attached for the usage list) and remove the api.php as it is not relevant anymore?

sokru made their first commit to this issue’s fork.

sokru opened merge request !4

sokru’s picture

sokru commented
Status: Needs work » Needs review

Might be that code on src/QueueSettings.php is not used at all 🤔

e.bogatyrev made their first commit to this issue’s fork.

  • berdir committed 94eb568a on 8.x-2.x authored by sokru 
    Issue #2842834 by sokru, e.bogatyrev, rgpublic, berdir: Remove...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Addressed my review, undid everything except removal of documented but unused hooks, merged. Cleaning up the settings plugins is not in scope, that's just all dead code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.