Problem/Motivation

The hooks introduced by the module are redundant as the jobs are implemented as config entities.

Proposed resolution

1. Deprecated the hook invokes -- probably removed in 3.x ?
1. update API documentation.

Remaining tasks

User interface changes

N/A

API changes

Probably as these hooks do not work anymore.

Data model changes

N/A

Original issue summary

There are some hooks defined in ultimate_cron.api.php which don't seem to actually work, specifically:

  • hook_cronapi
  • hook_cron_easy_hooks and hook_cron_easy_hooks_alter
  • hook_pre_invoke
  • hook_post_invoke
  • hook_ultimate_cron_plugin_build_operations
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

From the POV of API completion, I suggest resolving this for 2.0-beta1.

Robin.Houtevelts’s picture

wtf, been looking at this for way too long.

Berdir’s picture

Most of those hooks don't exist onpurpose and should be removed, cron jobs are defined using in config entities, see #2744129: Document how to create cron jobs.

rgpublic’s picture

Okay, first tentative attempt for a patch to move this issue forward.

Simon Georges’s picture

Status: Active » Needs review

Changing status to "Needs review", as there is a patch.

Status: Needs review » Needs work

The last submitted patch, 5: 2842834-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

Title: Ensure all documented hooks are actually triggered » Remove unnecessary hooks
Issue summary: View changes
FileSize
145.86 KB

Most of those hooks don't exist on purpose and should be removed, cron jobs are defined using config entities

If I understand this correctly, the task here is to remove those hooks getting fired (see attached for the usage list) and remove the api.php as it is not relevant anymore?

sokru made their first commit to this issue’s fork.

sokru’s picture

Status: Needs work » Needs review

Might be that code on src/QueueSettings.php is not used at all 🤔

e.bogatyrev made their first commit to this issue’s fork.