Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The hooks introduced by the module are redundant as the jobs are implemented as config entities.
Proposed resolution
1. Deprecated the hook invokes -- probably removed in 3.x ?
1. update API documentation.
Remaining tasks
User interface changes
N/A
API changes
Probably as these hooks do not work anymore.
Data model changes
N/A
Original issue summary
There are some hooks defined in ultimate_cron.api.php which don't seem to actually work, specifically:
- hook_cronapi
- hook_cron_easy_hooks and hook_cron_easy_hooks_alter
- hook_pre_invoke
- hook_post_invoke
- hook_ultimate_cron_plugin_build_operations
Comment | File | Size | Author |
---|---|---|---|
#8 | ultimate-cron.png | 145.86 KB | vijaycs85 |
#5 | 2842834-5.patch | 7.98 KB | rgpublic |
Issue fork ultimate_cron-2842834
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
DamienMcKennaFrom the POV of API completion, I suggest resolving this for 2.0-beta1.
Comment #3
Robin.Houtevelts CreditAttribution: Robin.Houtevelts commentedwtf, been looking at this for way too long.
Comment #4
BerdirMost of those hooks don't exist onpurpose and should be removed, cron jobs are defined using in config entities, see #2744129: Document how to create cron jobs.
Comment #5
rgpublicOkay, first tentative attempt for a patch to move this issue forward.
Comment #6
Simon Georges CreditAttribution: Simon Georges at Makina Corpus commentedChanging status to "Needs review", as there is a patch.
Comment #8
vijaycs85If I understand this correctly, the task here is to remove those hooks getting fired (see attached for the usage list) and remove the
api.php
as it is not relevant anymore?Comment #11
sokru CreditAttribution: sokru as a volunteer commentedMight be that code on
src/QueueSettings.php
is not used at all 🤔