Detected the error when hook_link_alter() is called:

Warning: in_array() expects parameter 2 to be array, string given in ng_lightbox_link_alter()
CommentFileSizeAuthor
#9 is_active_class_is-2840579-9.patch2.93 KBborisson_
#9 interdiff.txt2.43 KBborisson_
#4 2840579-4.patch512 bytesMirnaxvb
#2 facets-class_array-2840579-2.patch616 bytesckng
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckng created an issue. See original summary.

ckng’s picture

ckng
Primary language English
CreditAttribution: ckng at MyFineJob, O8 commented
Status: Active » Needs review
FileSize
facets-class_array-2840579-2.patch616 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Needs review » Reviewed & tested by the community

Thanks for this issue and the patch, this looks like a small thing that we did wrong. Setting to rtbc but I'm currently not committing things until we get #2772745: Search API integration doesn't check/define feature support of backends fixed.

Mirnaxvb’s picture

Mirnaxvb CreditAttribution: Mirnaxvb at Synetic commented
FileSize
2840579-4.patch512 bytes

Re-roll with proper base path for the patch.

  • borisson_ committed f169914 on 8.x-1.x authored by Mirnaxvb 
    Issue #2840579 by ckng, Mirnaxvb: 'is-active' class is not in array
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Reviewed & tested by the community » Fixed

  • borisson_ committed f109602 on 8.x-1.x 
    Revert "Issue #2840579 by ckng, Mirnaxvb: 'is-active' class is not in...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Fixed » Needs work

Back to active, this made the tests fail.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Status: Needs work » Needs review
FileSize
interdiff.txt2.43 KB
is_active_class_is-2840579-9.patch2.93 KB

Fixes the unit test fails.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Dazzle commented
Status: Needs review » Fixed

Committed, thanks again!

  • borisson_ committed c7bd081 on 8.x-1.x 
    Issue #2840579 by borisson_, ckng, Mirnaxvb: 'is-active' class is not in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.