Need code clean:

  1. Remove '!important'
  2. Check styles with static width, like: width: 60px !important;
CommentFileSizeAuthor
#8 Selection_022.jpg210.05 KBhog
#7 Screen Shot 2017-01-11 at 10.44.18 AM.png156.69 KBjrockowitz
#7 Test Element Multiple Webform Demo Site.png241.8 KBjrockowitz
#7 clean-2839876-7.patch1.02 KBjrockowitz
#5 clean-multiple-forms-css-2839876-5.patch1.11 KBhog
#5 interdiff-clean-multiple-forms-css-2839876-5.txt1.25 KBhog

Comments

HOG created an issue. See original summary.

hog’s picture

hog commented
Title: Clean webform.element.flexbox.csswebform.element.multiple.css » Clean webform.element.multiple.css
andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: #2839872: Clean webform.element.flexbox.css » #2839871: [Meta] Clean up CSS
hog’s picture

hog commented
Assigned: Unassigned » hog
hog’s picture

hog commented
StatusFileSize
new interdiff-clean-multiple-forms-css-2839876-5.txt1.25 KB
new clean-multiple-forms-css-2839876-5.patch1.11 KB
hog’s picture

hog commented
Assigned: hog » Unassigned
Status: Active » Needs review

Need manual review. Also need describe steps how to reproduce multiple table.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new clean-2839876-7.patch1.02 KB
new Test Element Multiple Webform Demo Site.png241.8 KB
new Screen Shot 2017-01-11 at 10.44.18 AM.png156.69 KB

The multiple element is currently only being using by the Webform (admin) UI.

Here is the test form (/form/test-element-multiple) and the multiple element is being used to manage #options.

I did the regression testing with !important removed and the widget is fine but we need to keep the width properties to ensure that the inputs resize correctly.

Finally, the multiple element is still under heavy development and no one should be using it on a public facing form... yet.

hog’s picture

hog commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Selection_022.jpg210.05 KB

I tested this patch. With static with for controls is ok.

  • jrockowitz committed baf2754 on 8.x-5.x 
    Issue #2839876 by HOG, jrockowitz: Clean webform.element.multiple.css
jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.