Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
After last module release i see many bad css code.
We have code like this:
.webform-list-table th:last-child,
.webform-list-table td:last-child {
padding: 0 2px;
vertical-align: middle;
text-align: center !important;
width: 60px !important;
}Proposed resolution
- I think we need clean it.
- For each task need need add screenshot to be sure that patch don't break styles in project which use old module version.
Tasks list:
- #2839897: Resend submission's email sends encoded html tags
- #2839883: Clean webform.theme.seven.css
- #2839882: Clean webform.theme.bartik.css
- #2839881: Clean webform.element.toggle.css
- #2839879: Clean webform.element.states.css
- #2839878: Clean webform.element.signature.css
- #2839876: Clean webform.element.multiple.css
- #2839875: Clean webform.element.location.css
- #2839874: Clean webform.element.likert.css
- #2839873: Clean webform.element.html_editor.css
- #2839872: Clean webform.element.flexbox.css
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | meta_clean_up_css-2839871-10.patch | 19.71 KB | jrockowitz |
| |||
Comments
Comment #2
jrockowitz CreditAttribution: jrockowitz as a volunteer commented@HOG The Webform module is still in beta and someone should just start addressing any CSS issues. I would not worry too much about introducing any regressions. Developers and site-builders should be reviewing their site with every beta-to-beta update.
The webform_test.module includes working examples for every element and feature that can be used to check for any regressions.
Once there is a stable release we will have to be careful not to introduce any regressions. Right now we should just get the job done.
Comment #3
HOG CreditAttribution: HOG at Skilld, Drupal Ukraine Community commented@jrockowitz, i agree with you. But our team use this module in project & after update some styles broke. It was a little pain.
Comment #4
HOG CreditAttribution: HOG at Skilld, Drupal Ukraine Community commentedComment #5
andypost@jrockowitz Good point! I think better to clean-up styling while in beta stage, this way it gets more attention from community and feedback
@Hog please update child issues to point this one as parent
Comment #6
HOG CreditAttribution: HOG at Skilld, Drupal Ukraine Community commentedComment #7
HOG CreditAttribution: HOG at Skilld, Drupal Ukraine Community commentedComment #8
jrockowitz CreditAttribution: jrockowitz as a volunteer commented@HOG and @andypost As we are going through these tickets, I think you are gradually seeing that there is definitely some (undocumented) reason/logic behind all the existing CSS.
I think it might help if we define what exactly needs to be fixed...
For example,
Is there anything else that needs to be addressed?
Moving forward, I think adding a /webform/css/README.md file with Webform specific guidelines and links will help.
Once we define these guidelines, I can do a review, cleanup, and commenting of all the CSS file.
Comment #9
jrockowitz CreditAttribution: jrockowitz as a volunteer commentedI am going to create patch that adds more description comments to all the existing CSS files.
Comment #11
jrockowitz CreditAttribution: jrockowitz as a volunteer commentedThe attached patch adds more comments, @see references, and removes some unused selectors and stylesheets.
If all the tests pass, I am going to commit this patch and then I will start reviewing all the sub-tickets.
Comment #13
jrockowitz CreditAttribution: jrockowitz as a volunteer commented