Problem/Motivation

The title tag for the menu link is generated from the description field. This leads to situation like these:

Proposed resolution

Add an option to select the field for the description when creating a taxonomy menu. Also provide a none option such that the description field can be made optional.

Remaining tasks

PR needs review.

User interface changes

Adds a new Description field field to the taxonomy menu creation form.

API changes

Adds a description_field_name mapping to the config schema.
Adds a getDescriptionFieldName method to TaxonomyMenuInterface.
Rewrites the getDescription for TaxonomyMenuMenuLink

CommentFileSizeAuthor
#8 2831437-8.patch4.81 KBdstol
#6 2831437-6.patch6.63 KBpk188
#5 Screen Shot 2017-07-03 at 8.39.50 AM.png113.96 KBadrian83

Comments

arshadcn created an issue. See original summary.

shadcn’s picture

shadcn commented
Status: Active » Needs review

See related PR: https://github.com/unn/taxonomy_menu/pull/5

shadcn’s picture

shadcn commented
Issue summary: View changes
sascher’s picture

sascher commented

Hey I tested this using the patch from the above link and it worked pretty good. I created a custom test field called "title" and it presented the "field_title" option in the dropdown and showed through in the front end.

adrian83’s picture

adrian83 commented
StatusFileSize
new Screen Shot 2017-07-03 at 8.39.50 AM.png113.96 KB

So far, this is my favorite solution to the issue in the screenshot, namely, that on hover over taxonomy menu links, if the taxonomy description is long, the title for that menu item is also long.

pk188’s picture

pk188 commented
StatusFileSize
new 2831437-6.patch6.63 KB

Using #2.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Reviewed & tested by the community

Patch adds a configurable description field , applies cleanly.

dstol’s picture

dstol
Primary language English
commented
StatusFileSize
new 2831437-8.patch4.81 KB

Better patch without all the mode changes.

  • dstol committed e26cfa2 on 8.x-3.x authored by arshadcn 
    Issue #2831437 by pk188, dstol, Adrian83, arshadcn: Make the description...
dstol’s picture

dstol
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.