Fix spelling errors in Drupal core comments

There were a few items missed in the last patch:

-                        // No sure it's enough for a magic code ....
+                        // Not sure it's enough for a magic code ....

should be *and*:

-     * rand remove double slashes.
+     * and remove double slashes.

Hyphenate user-specific:

- * submission, the contents of a shopping cart, or other user specific content
+ * submission, the contents of a shopping cart, or other user-specific content

Incorrect verb use:

-   * Registers that update functions got executed.
+   * Registers that update functions were executed.

Properly mark machine name of permissions in text with quotes

-      // Only users with either post comments or access comments permission can
+      // Only users with "post comments" or "access comments" permission can

More than 80 characters long:

-      // The first tab key press is tracked so that an announcement about tabbing
+      // The first tab key press is tracked so an announcement about tabbing

Add comma after introductory phrase:

-    // Prior to negotiation the override language should be the default
+    // Prior to negotiation, the override language should be the default

It's jQuery, not Jquery:

-/* Hide the default Jquery UI dialog close button. */
+/* Hide the default jQuery UI dialog close button. */

Use the verb "set" to match the setter method:

-    // Make the body field unlimited cardinality.
+    // Set the body field to unlimited cardinality.

Comma after introductory phrase & reduce prepositions:

-  // For backwards compatibility switch the visibility of the methods to public.
+  // For backwards compatibility, switch the method visibility to public.

Avoid newspaper headline speak:

-    // Page still accessible but there should not be menu link.
+    // Page is still accessible but there should be no menu link.

Style:

-    // to $_SERVER['REQEUST_URI'] and friends. Therefore it is necessary to
+    // to $_SERVER['REQUEST_URI'] and friends. It is therefore necessary to

Capitalize HTML:

- * Tests that the allowed html configurations are updated with attributes.
+ * Tests that the allowed HTML configurations are updated with attributes.

Hyphenate compound verb:

- * Example implementation of accept header based content negotiation.
+ * Example implementation of "accept header"-based content negotiation.

Avoid newspaper speak:

-    // Check original string.
+    // Check the original string.

Hyphenation:

-   * Should be a fully qualified class name that implements
+   * Should be a fully-qualified class name that implements

Offset letter in quotes:

-    // This is a Cyrillic character that looks something like a u. See
+    // This is a Cyrillic character that looks something like a "u". See

Spelling corrected.

+++ b/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php
@@ -531,7 +531,7 @@ protected function loadFromSharedTables(array &$values, array &$translations) {
+            // \Drupal\Core\Entity\Sql\TableMappingInterface:: getColumnNames()

Extra whitespace here.

Thanks vaplas,
I add to re-roll the patch.
I removed thema.api.php change because another patch did a better previous (conflicting) change and wording seems ok for me.

I changed also EntityAutocomplete.php patch part because the point seems to be on correcting "unambuguously" in "unambiguously", and in the following text "still" would add no meaning while "silly" is ... silly (bad in comment) ;-).
- * matches the incoming input, and sill assign form errors otherwise.
+ * matches the incoming input, and assign form errors otherwise.

Needs work -> needs review

Random test issues on XX are not related to this patch. See https://www.drupal.org/node/2832853.

Mainly concerning UpdatePathTestBase.php. See https://www.drupal.org/project/issues/drupal?text=random+fail+UpdatePath...
or ArgumentPlaceholderUpdatePathTest.php. See https://www.drupal.org/project/issues/drupal?text=random+fail+ArgumentPl...

All tests passed today. Lets review please.

I just applied both: d83_only-2829185-18.patch and d82_and_d83-2829185-18.patch on a local fresh install of Drupal 8.3. I then did a git diff to see the changes and can verify the spelling changes are correct.

Review Patch #18 -"d83_only-2829185-18.patch" the spelling changes are correct.
I think unused comment in core/modules/language/src/Config/LanguageConfigFactoryOverride.php file .
please refer screenshot

Great work on this issue so far!

It seems like this is a lot more than a few spelling errors. :) Based on the core issue scope policy and the scope @catch and I identified in #2622992: Run a spellchecker against core and fix all the errors in comments, we should spellcheck all of core and fix all the straightfoward spelling errors in a single patch if possible.

It seems like this issue is on its way to accomplishing that. Can someone document what spellcheck method is being used, and document a summary of spelling errors in code comments before vs. after the patch?

I'm new to here here is my little change.

Use standard issue summary template.

I found Typo error (The word 'messages' is misspelled as 'mesages'.) in FormValidationMessageOrderTest.php. Fixed the typo error and attached patch, please review.

@Munavijayalakshmi Usually what we need in an issue contribution is to start with the prior working patch and add the new changes.

For #41 and being that a new problem was discovered, this needs work.

Patch no longer applies so re-rolled. Tried to correct the error mentioned in #40, but cannot find FormValidationMessageOrderTest.php or the string "mesages".

Now rolled against the correct version. And, as if by magic, I can now see (and correct) the typo identified in #40! Time to go home, methinks...

Went through all the parts of the core and I think so that all the spelling errors have been corrected. So changing the status to RTBC.

Patch still applies to HEAD. Retesting and back to RTBC as per #46.

Nice work everybody. The first thing that I do when evaluating an issue is to make sure the patch is fixing the thing mentioned in the issue title.

As noted in #29, in addition to spelling fixes there are wording changes that are not necessarily grammar fixes. That is not a problem in itself, but we want to make sure we retain the meaning of the comments. Following are two examples I saw. I do not think there are many such changes in the patch.

1. +++ b/core/modules/simpletest/src/TestBase.php
   @@ -27,7 +27,7 @@
   -  // For backwards compatibility switch the visbility of the methods to public.
   +  // For backwards compatibility, switch the method visibility to public.
   

2. +++ b/core/modules/system/src/Tests/Session/SessionHttpsTest.php
   @@ -190,7 +190,7 @@ protected function getPathFromLocationHeader($https = FALSE, $response_code = 30
   -    // to $_SERVER['REQEUST_URI'] and friends. Therefore it is necessary to
   +    // to $_SERVER['REQUEST_URI'] and friends. It is therefore necessary to
   

Patch in #45 failed to apply. Fixed it and improved it by taking suggestion in #51.

Even this patch applies well and also has passed all the tests. So changing to RTBC. Guess it works well.

So that we can evaluate whether all comment typos are fixed, would someone please attach the list of allowed tech words that were added to the PHPStorm dictionary (Editor -> Spelling -> Accepted Words)? This way we can repeat the scan with and without the patch applied and we could review the list of accepted words.

Thank you!

@cilefen
How about committing it early but then file a follow up like #2972224: Add .cspell.json to automate spellchecking in Drupal core.

#60 looks good spelling mistakes corrected.

Also need to add changes from
#2989612 - Fix typos in Views UI module.

Re-rolled.

Added change from #2989612: Fix typos in Views UI module. (the other 2 out of 3 were already included).

Due to some recent changes, patch does not apply:

error: patch failed: core/modules/simpletest/src/Tests/InstallationProfileModuleTestsTest.php:19
error: core/modules/simpletest/src/Tests/InstallationProfileModuleTestsTest.php: patch does not apply

It would be better if this issue get fixed, otherwise we need to re-roll every another day.

+++ b/core/lib/Drupal/Core/Config/FileStorage.php
@@ -46,7 +46,7 @@ public function __construct($directory, $collection = StorageInterface::DEFAULT_
-    // internal statc caching of FileCache is used and thus avoids blowing up
+    // internal stat caching of FileCache is used and thus avoids blowing up

Is this supposed to be "static"? "stat" does make some sense when talking about files but not sure it was what was intended here.

"Static": it's part of this issue and commit (but FWIW, I'd have guessed "state" before I looked that up…)

Needs work based on #68/69

I checked all the fixes in the patch and they all look good to me.

As this is such a moving target I don't believe we will ever fix all the spelling in a single issue, so I think this should be committed now and followups can be opened for any new or existing spelling issues.

@xjm @
Just want to check if any plans to commit this to the Drupal 8.7 DEV core ?

Needs a reroll :(

error: core/modules/file/src/Tests/FileManagedFileElementTest.php: does not exist in index

That's become a PHPUnit based test now.

Re-rolled

Double checked the reroll, all good.

This is a good moment to commit this patch. We have a followup to automate spellchecking in place. I t applies to 8.7.x and 8.6.x so patches will apply to both actively published branches. And the issue has been rtbc many times.

Committed and pushed 2dabd1de10 to 8.7.x and 6dfc00c0f4 to 8.6.x. Thanks!