Attached patch should get the main module rolling (didn't touch colors, legend and GoogleCalendar).

It should be possible to move events between days, and change their start/duration time and have those settings persist.

By default it filters by date of all date fields added under 'FIELDS', it should be possible to add additional exposed filters (e.g. Tags) under 'FILTER CRITERIA' and be able to narrow events even further, if there are exposed filters defined it should not hide their widgets and 'Apply' button.

done:
- updated .js to be compatible with latest fullcalendar lib (3.0.1)
- changed AJAX update controller to support eventResize and added some validation to it
- added 'Date only' fields handling
- update views 'use ajax' code, account for no more 'date_select' widget and changed markup/classes
- minor: ".fc-button" was hardcoded, theme variable (this.tm) was badly set
- added rudimentary timezone handling (uses user's default, needs work, config?)

todo:
- 'data-editable' is hardcoded in src\Plugin\views\style\FullCalendar.php
- initial render of the view still gets all? events into html
- review 'options'/config changes between 1.x and 2.x/3.x of fullcalendar lib (https://fullcalendar.io/wiki/Upgrading-to-v2/)
- untangle $view->getExposedInput() / settings.fullcalendar_fields_count / options['fields']['date_field'] interactions in fullcalendar.views_execution.inc:fullcalendar_views_pre_view() and fullcalendar.ajax.js:Drupal.fullcalendar.fullcalendar.prototype.submitInit()
- check/fix sub modules

note:
- there is no view filter plugin for daterange, so no 'between' filter, use with patch from #2786577: The Views integration Datetime Range fields should extend the views integration for regular Datetime fields if you use daterange fields (rebuild core, flush caches, run updates, might need to re-edit the old views even after that)
- not sure 'between' is the way to go anyway, maybe custom filter will be needed for 'daterange' (end_value > min, value < max)
- jQuery selectors in Drupal.fullcalendar.fullcalendar.prototype.submitInit() might be a bit loose, but it seems there are no views specific classes in exposed widgets
- jQuery.fullCalendar() breaks chaining
- many parts of the code could use refactoring, commenting, plenty of old @todos

CommentFileSizeAuthor
#22 2828939-22-ajax-fix-combined.patch40.35 KBnickdickinsonwilde
#18 2828939-18-ajax-fix-combined.patch40.51 KBtacituseu
#16 2828939-16-ajax-fix-combined.patch41.57 KBgriddick
#16 interdiff-2828939-14-2828939-16.txt1.53 KBgriddick
#14 2828939-14-interdiff.txt12.05 KBtacituseu
#14 2828939-14-ajax-fix-combined.patch41.3 KBtacituseu
#13 2828939-13-interdiff.txt1.58 KBtacituseu
#13 2828939-13-ajax-fix-combined.patch29.7 KBtacituseu
#12 2828939-12-ajax-fix-combined.patch29.27 KBtacituseu
#4 2828939-4-ajax-fix-combined.patch29.3 KBtacituseu
#2 2828939-2-ajax-fix-combined.patch30.34 KBtacituseu
#2 2828939-2-ajax-fix.patch28.68 KBtacituseu

Comments

tacituseu created an issue. See original summary.

tacituseu’s picture

tacituseu commented
Status: Active » Needs review
StatusFileSize
new 2828939-2-ajax-fix.patch28.68 KB
new 2828939-2-ajax-fix-combined.patch30.34 KB

Attaching 2 patches:
- 2828939-2-ajax-fix.patch requires: 2827950+2827939+2827936+2827930-combined.patch from #2827950: Call to undefined function l() in AJAX Update controller
- 2828939-2-ajax-fix-combined.patch should work against current HEAD

tacituseu’s picture

tacituseu commented
Issue summary: View changes
tacituseu’s picture

tacituseu commented
StatusFileSize
new 2828939-4-ajax-fix-combined.patch29.3 KB

Updated for head changes

tacituseu’s picture

tacituseu commented
arosboro’s picture

arosboro commented

Nice work @tacituseu. I've installed this patch and was able to configure a View. Library detection is not working on the most recent version of the jquery dependency. I get

FullCalendar plugin At least 1.5.0
You need to download the !fullcalendar and extract the entire contents of the archive into the /libraries folder of your server.

What library version were you using?

arosboro’s picture

arosboro commented
Status: Needs review » Reviewed & tested by the community

I have tested and confirmed that the following composer patch applies and restores functionality as expected:

 "drupal/fullcalendar": {
        "Restore AJAX functionality":
        "https://www.drupal.org/files/issues/2828939-4-ajax-fix-combined.patch"
}

The following actions have been tested:

  • Calendar renders using JQuery UI theme
  • Change view between month, week, day, today
  • Navigate forward and backward
  • Two date fields although not using date-range with a single field
  • Change date using ajax updates both fields correctly
tacituseu’s picture

tacituseu commented

Patch is based on fullcalendar-8.x-1.x-dev (8.x-1.x in repository) and fullcalendar-3.0.1.
fullcalendar-8.x-1.0-alpha2 should not be used (or displayed on download page even) as it is 3 years old.

arosboro’s picture

arosboro commented

Yes, I eventually figured that out, and have dev branch installed in my project. The library issue seemed to resolve itself.

arosboro’s picture

arosboro commented

is anyone maintaining this project atm?

martin107’s picture

martin107 commented

There are a few willing people lurking about, but I am afraid the answer seems to be No :)

tacituseu’s picture

tacituseu commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2828939-12-ajax-fix-combined.patch29.27 KB

Left one drupalSettings.path.basePath in eventResize.

@arosboro: 'Looked at once in a full moon' would be the proper maintenance status :), at least on d.o., there's also a git repo, maybe new maintainer expects work to magically happen there, so far it is just a garden of empty issues.

tacituseu’s picture

tacituseu commented
StatusFileSize
new 2828939-13-ajax-fix-combined.patch29.7 KB
new 2828939-13-interdiff.txt1.58 KB

Adds support for views with arguments.

tacituseu’s picture

tacituseu commented
Issue summary: View changes
StatusFileSize
new 2828939-14-ajax-fix-combined.patch41.3 KB
new 2828939-14-interdiff.txt12.05 KB

- fixes 'Enable advanced time and date format settings' not being applied (ref: https://fullcalendar.io/docs/views/View-Specific-Options/).
- fixes #2853942: Libraries are not attached for plugins and upgrades fullcalendar_options

tacituseu’s picture

tacituseu commented
Related issues: +#2648950: [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter

It will need a rework after #2648950: [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter gets in.

griddick’s picture

griddick commented
StatusFileSize
new interdiff-2828939-14-2828939-16.txt1.53 KB
new 2828939-16-ajax-fix-combined.patch41.57 KB

Great work tacituseu thanks!
I have just started playing with your changes against the latest 3.4.0 release of fullcalendar. One small extra change required due to deprecated methods.

tacituseu’s picture

tacituseu commented

@griddick: looking at the source of fullcalendar-3.4.0.zip even though those properties were deprecated, they are still kept there for backward compatibility, so it should work without those changes, might be worth keeping it compatible with all of 3.x vs only latest.

tacituseu’s picture

tacituseu commented
StatusFileSize
new 2828939-18-ajax-fix-combined.patch40.51 KB

Re-rolled after #2848422: White Screen of Death (WSD).

socialnicheguru’s picture

socialnicheguru commented

I can install the module with this patch using the dev version.

have not fully tested the functionality yet though.

tacituseu’s picture

tacituseu commented

There is some recent movement in github repo by @lonalore (see: https://github.com/dakala/fullcalendar/pull/22), you might want to check it out too.

brooke_heaton’s picture

brooke_heaton commented

This patch no longer applies clean for me.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
StatusFileSize
new 2828939-22-ajax-fix-combined.patch40.35 KB

Rerolled

mrpauldriver’s picture

mrpauldriver commented

Could not install patch 22

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
tacituseu’s picture

tacituseu commented
Status: Needs work » Closed (outdated)

Latest dev has integrated an alternative patch provided by @lonalore over at github repo, so it should no longer be needed (didn't test it yet).

mrpauldriver’s picture

mrpauldriver commented
Status: Closed (outdated) » Active

With respect, I don't think we can close this issue, marking it outdated, whilst it is causing problems right now. That there is a fix over at github does not mean it should not posted here.

tacituseu’s picture

tacituseu commented

@MrPaulDriver: The reason the patch doesn't apply is because the fix is no longer only at github, it was merged into latest 8.x-1.x-dev on D.O. (5ff71c7). Give it a try.

mrpauldriver’s picture

mrpauldriver commented
Status: Active » Closed (outdated)

Understood. Thank you for the explanation.