Remaining:
#2346097: Use fullcalendar.permissions.yml
#2827930: "Undefined index: display" errors after changing view's format
#2827936: Bad URL in AJAX requests
#2827939: Error: Call to undefined method Drupal\Core\Access\AccessResultAllowed::cachePerRole()
#2827950: Call to undefined function l() in AJAX Update controller
#2828939: Restore AJAX functionality
#2853942: Libraries are not attached for plugins
Original post:
It has been a little time since this module was updated --- core is constantly changing.
This is just a parent issue for a bunch of narrowly focused issue digging through change records and restoring basic functionality.
I can see 2 issue that need solving ... and that was within the first 5 mins of looking so I expect more.
1) We are still using String::checkPlain - when SafeMarkup::checkPlain is the well established replacement
2) drush en fullcalendar identifies compatibility issues with Drupal\fullcalendar\Form\SettingsForm
3) The l() function has been removed from core.
4) submitForm method needs work.
Nice to have:
While not strictly essential to restoring basic functionality. From experience whenever I am working on these types of projects
with coupled javascript I have found converting all the legacy javascript to using strict CAN resolve lots of funnies ahead of time.
Comments
Comment #1
martin107 CreditAttribution: martin107 commentedadded the "use strict" nice to have.
Comment #2
martin107 CreditAttribution: martin107 commentedupdated issue summary with l() issue
Comment #3
martin107 CreditAttribution: martin107 commentedadded submitForm() issue
Comment #4
martin107 CreditAttribution: martin107 commentedComment #5
tacituseu CreditAttribution: tacituseu commentedComment #6
tacituseu CreditAttribution: tacituseu commentedComment #7
tacituseu CreditAttribution: tacituseu commentedComment #8
dakala@tacituseu: Thanks for bringing this issue to light. On a cursory look, I don't think most of the points are still valid. anyhow, let's focus on the code here https://github.com/dakala/fullcalendar which is same as https://git.drupal.org/project/fullcalendar.git and takes things from there.
Comment #9
tacituseu CreditAttribution: tacituseu commentedIt is based on latest https://git.drupal.org/project/fullcalendar.git, added my issues under 'Remaining' and as child issues.
Comment #10
tacituseu CreditAttribution: tacituseu commentedChanged issue summary, created new child issue with working patch #2828939: Restore AJAX functionality.
Comment #11
tacituseu CreditAttribution: tacituseu commentedComment #12
tacituseu CreditAttribution: tacituseu commented