No redirection to term view display page from term edit page

Patch failed.. When creating new term it should not redirect to term view page, only editing term should redirect to term view page.

Hi Sourabh,

You are absolutely right, this works fine for me as well. But the issue I am talking about is while creating new term. It should not redirected to term view page.Add time redirection works without patch but with patch it redirects me on view page. Please let me know if you need any clarification.

Thanks

Hi Sourabh,

Now Patch works well as per the requirements.

Thanks

Does Drupal 8 have this issue as well? If yes, it needs to be fixed there first

Hello sourdrup,

Thanks! Your patch works well with Drupal 8.2.3.
Also Thanks @stefan.r

By the way, nice job catching the fact that we want this redirect to be on the "edit" form only, not the "add" form. I definitely think that makes sense, since when adding taxonomy terms it is common to add a few at once.

Changing this to 'needs work' – to get it into core we first a patch name without -do-not-test, so it can be run on testbot.
@sourdrup - I'll also unassign the issue so there's a greater chance of others picking it up if you don't have time yourself (see Assigning Ownership docs)

Re rolled as #11 failed to apply. And fixed #15.

Needs tests. I don't understand why the path based edit check is necessary, this is already within the UPDATE case, where we know that we are updating a term?

Updating this patch for 9.x and adding a couple of tests.

Fixed the array syntax. That's what I get from cutting and pasting from a previous patch.

At the time of applying patch#26 on the drupal 9.1.x dev version getting an error and not able to apply the patch. Please refer attached error screenshot.

Hopefully this attached patch will be useful

I tried to apply these patches but getting error for reference sharing screenshot

Here's a patch for 9.3.x

I tested this on 9.3.x, standard install and when editing a taxonomy term, clicking save, I return to the the term list page. Just to be sure I understood the problem I applied the patch and edited and saved a term. I was again sent to the term list page. The patch does not change the current behavior.

A reminder to anyone working on older patches is to reproduce the problem first. If it can't be reproduced then explain what you did in a comment and close it as cannot reproduce. Lets put our collective efforts into problems that still exist.

Closing as cannot reproduce.

@quietone: I can reproduce the described problem. The difference lies in a small but important detail: from where you click the edit button.

As @sourabh.singhal describes it, its about the term view page ('/taxonomy/term/[tid]') where "edit" is clicked. Like you would edit a node in frontend via the edit tab. The expected behaviour when you click save would be to return to the view/full page where you clicked "edit" (as it is with nodes).

But when doing so with a taxonomy term, you click save but you stay on the edit form with success message that the term has been updated.
Yay! But please take me back to the view page. ;)

I can confirm that the patch from #33 leads to the desired behaviour.

@shortspoken, thanks for the explanation. I retested on 9.5.x, this time correctly, and did reproduce the problem.

Setting back to NR.

Applied patch #33 in 9.5.x successfully. The patch fixes the issue. Adding screen recording for reference

Patch #33 Applied and tested successfully on Drupal 9.5.x.

Steps to reproduce:
1. Create a new term in the Vocabulary.
2. Open the term page and click the edit page. Screen will be redirect to the term edit page.
3. Now save the edit form. Screen not redirect to the Term page.
4. Apply the Patch and try to save the edit form screen will be redirect to the term View page.

Before-Patch:

After=Patch:

Tested on Drupal 9.5.x

- Issue summary is clear and was able to reproduce the issue
- The patch #33 applies cleanly
- After applying the patch the redirect works as expected. Not adding a before after patch coz #39 already has provided it
- Test is included
- No issues seen in the code

Moving to RTBC

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!