Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Nov 2016 at 01:41 UTC
Updated:
27 Dec 2016 at 17:26 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
sanjay chauhan commentedHi @samaphp
As you are using system_settings_form (force_logout.form.inc) to set variable, use hook_uninstall for deleting those variables from table.
Variable "force_logout_status" and "force_logout_login_message" needs to be deleted on module uninstall.
Also please change doc block comment text (Implements hook_permission() -> Implements hook_menu()) from force_logout_menu() (Line #9).
Thanks
Comment #4
samaphp@Sanjay Chauhan
Thank you, your notes has been resolved.
Thanks again for your time.
Comment #5
saveva commentedHello samaphp.
Your README.txt/README.md does not follow the guidelines for in-project documentation and/or the README Template.
You should consider as well to include the updated version in the administration help in your hook_help.
Regards.
uh
Comment #6
amit.drupal commentedHello Samaphp.
Follow the Coding standers and sequence of hook function.
Example - hook_help define in top of module .
Thanks
Comment #7
PA robot commentedGit clone failed for https://git.drupal.org/sandbox/samaphp/2406825.git while invoking http://pareview.sh/pareview/httpsgitdrupalorgsandboxsamaphp2406825git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.