Separate URL and settings permissions

This patch separates the settings page into a new permission and adds a hook_update_n to maintain existing access for sites with this module already installed.

Hmmm strange it is stuck on 'Running' for a few hours now. Will see if switching it to needs review will jolt it back to life.

Updated patch to match changes since patch originally submitted (no change besides hook_update_n number), should apply now.

Updated with changes to test permissions to match new permission change

Hmmm I am not sure how to handle the access in the Redirect404Operations views field. Does it need to have add and ignore placed into two separate fields? It seems the access method in there is an all or nothing for the contents of the render (or am I looking at it wrong?). Am I right in assuming it is not appropriate to wrap the Ignore operation in an if statement with something like:

$user = \Drupal::currentUser();
if ($user->hasPermission('administer redirect settings')) {
  // Etc.
}

Stepping back a bit, perhaps a site editor who is not allowed to change the global redirect settings should still be allowed to ignore a 404 URL. I imagine that would be a bit more complicated since you use the redirect global config to handle ignores (redirects = content and redirect 404 ignores = config?).

Re the permission descriptions, is this more accurate:

administer redirects:
  title: 'Administer individual URL redirections'
administer redirect settings:
  title: 'Administer global URL redirection settings'

Sounds good thanks! I couldn't see how to make access work on a single link as both links get added to the same render element (putting #access on the link has no effect) so I did go with the if statement. Added in the user via dependency injection. Also updated the 404 routing yml file accordingly.

If you are happy with this one after the above discussion, okay to mark as 'reviewed and tested by the community'.

Please let me know if you have any further issues or blockers on this that you'd like me to address.

Thanks!
Scott

Sounds good thanks!

Thanks and no problem!