If a form submission in IPE results in validation errors, the errors messages are not displayed anywhere as they would be in normal core contexts.

CommentFileSizeAuthor
#17 2825034-17.patch4.45 KBjoseph.olstad
#16 2825034-14.patch3.88 KBjoseph.olstad
#7 2825034-6.patch4.56 KBsamuel.mortenson
#5 panels-ipe-propogate-errors-2825034-5.patch733 bytessamuel.mortenson

Issue fork panels-2825034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

TravisCarden created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Related issues: +#2809841: Plan for Panels 8.x-3.0-beta6
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Needs tests
Parent issue: » #2809841: Plan for Panels 8.x-3.0-beta6
Related issues: -#2809841: Plan for Panels 8.x-3.0-beta6
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2809841: Plan for Panels 8.x-3.0-beta6 » #2852655: Plan for Panels 8.x-4.8 release

Punting to the next beta.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new panels-ipe-propogate-errors-2825034-5.patch733 bytes

Wow, this is super annoying! Here's a patch which resolves the issue for me.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Needs work

Lightning has been using this patch in its last several releases, so I'd mark it RTBC...but it needs tests :)

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2825034-6.patch4.56 KB

@phenaproxima As you wish, here is a test.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented

Test failures are on the branch: https://www.drupal.org/node/74958/qa

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Version: 8.x-3.x-dev » 8.x-4.x-dev
minoroffense’s picture

minoroffense commented

This appears to be fixed by https://drupal.org/node/3031778

minoroffense’s picture

minoroffense commented
Related issues: +#3031778: Change panels store
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

Indeed, I have confirmed that #3031778: Change panels store includes the exact same code, although not the test.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@todo

take the test from patch #7

joseph.olstad opened merge request !21

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Form error messages do not appear in IPE » Update test coverage for "Form error messages do not appear in IPE"
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 2825034-14.patch3.88 KB

see if the legacy tests work

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 2825034-17.patch4.45 KB

patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

joseph.olstad closed merge request !21

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

MR 21 adds a fail and an error, closed MR

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (outdated)