Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Looks good. Committed! I think it might warrant making a release.
Comment | File | Size | Author |
---|---|---|---|
#53 | image-3031778.png | 126.48 KB | thalles |
#51 | interdiff_3031778_37_51.txt | 3.23 KB | YurkinPark |
#51 | panels_tempstore-updated-3031778-51.patch | 26.5 KB | YurkinPark |
#37 | panels_tempstore-updated-3031778-37.patch | 23.37 KB | iyyappan.govind |
#34 | panels_tempstore-updated-3031778-34.patch | 24.58 KB | sameer_khan |
Comments
Comment #2
pyxio CreditAttribution: pyxio commentedComment #3
pyxio CreditAttribution: pyxio commentedComment #4
aperedos CreditAttribution: aperedos commented+1 I have the same problem.
Comment #5
scotthooker CreditAttribution: scotthooker commented+1 same
Comment #6
desierto CreditAttribution: desierto commentedYes, indeed same problem. Panels Version: 8.x-4.3. Drupal 8.6.9.
Also clicking "Content" under "Variants" does not drop down the sub-menu in Seven theme unless I hit update and save, then it will only once. In Adaptive Theme it will not at all.
Comment #7
aperedos CreditAttribution: aperedos commentedComment #8
aperedos CreditAttribution: aperedos commentedIt´s not possible to work with panels in this version, because you cannot create new blocks, delete or edit existing blocks, or create new context...It fails for any action.
Comment #9
george.karaivanov CreditAttribution: george.karaivanov at Peytz & Co commentedSame story
Comment #10
remkoklein CreditAttribution: remkoklein commenteddowngrade ctools to 3.0.0 until this issue is fixed.
Comment #11
gaspounet CreditAttribution: gaspounet as a volunteer commentedDowngrading ctools to 3.0 worked for me and resolved another critical error with panels and easy breadcrumbs, thank you!
Comment #12
lamp5The same issue on my sites. Downgrade ctools to 3.0 works. Thanks.
Comment #13
iyyappan.govindSame issue here, But ctools required by lot of other modules. So I can't downgrade the ctools module. Is there other way to do it? Thanks
Comment #14
artematem CreditAttribution: artematem at FFW commented@iyyappan.govind
what is blocking you from downgrading?
In composer
"drupal/ctools": "3.0"
or"drupal/ctools": "3.0 as 3.1"
(if it will work).Comment #15
manuel.adan#2936263: User's temp stores has been moved to core for 8.5.x in ctools makes panels to fail.
The SharedTempStoreFactory was moved in D8.5 from the user module to the main core. Although the old class extends the new one, they do not share the same storage. Panels still uses the SharedTempStoreFactory from the user module, that stores values in the "user.shared_tempstore.$collection" store, while ctools uses the new factory which stores its values in the "tempstore.shared.$collection" store.
Panels must be refactored to use the same SharedTempStoreFactory instance as ctools.
Comment #16
cobenash+1 same
Comment #17
lyalyuk CreditAttribution: lyalyuk at Drupal Ukraine Community for Drupal Ukraine Community commentedsubscribe
Comment #18
drupgirl CreditAttribution: drupgirl commented+1, downgrading ctools to 3.0 works. thx, remkoklein, for the heads up.
Comment #19
iyyappan.govind@artematem
If I downgrade the module means, It will affect the database updates if present. How could we manage database updates? Thanks
Comment #20
iyyappan.govindI am getting error which is attachment.
Comment #21
nickolajComment #22
iyyappan.govind@nickolaj
Let me test your patch. Thanks
Comment #23
lamp5Comment #24
manuel.adanAfter the patch, there are still references to the deprecated class:
Comment #25
iyyappan.govindHi @nickolaj
Patch works fine. Also we need to change the panelizer pattern to use the core's tempstore. Here is the issue
https://www.drupal.org/project/panelizer/issues/3034080
Thanks
Comment #26
nickolajHi @iyyappangovind-0!
You're welcome!
Thank you.
Comment #27
iyyappan.govindHere is the updated patch file. Thanks to nickolaj and manuel.adan
Comment #28
iyyappan.govindComment #29
manuel.adanAfter #27, still:
Comment #30
iyyappan.govindHere is the updated patch file.
Thanks
Comment #31
iyyappan.govindComment #32
iyyappan.govindComment #33
iyyappan.govindFixed below error identified by testing
PHP Parse error: syntax error, unexpected 'use' (T_USE), expecting ',' or ';' in /var/www/html/modules/contrib/panels/panels_ipe/src/Helpers/RequestHandlerBase.php on line 11
Comment #34
sameer_khan CreditAttribution: sameer_khan commentedThanks @iyyappan.govind and @nickolaj for your patches.
I had a few issues with the previous patches, so made some changes. Replacing \Drupal\user\SharedTempStore with \Drupal\Core\TempStore\SharedTempStore and Drupal\user\SharedTempStoreFactory with Drupal\Core\TempStore\SharedTempStoreFactory.
Seems to be working fine for me.
Comment #35
sameer_khan CreditAttribution: sameer_khan commentedComment #36
manuel.adanPatch #34 doesn't apply for me (syntax error at line 10).
Comment #37
iyyappan.govindHere is the correct patch file.
Thanks
Comment #38
iyyappan.govindComment #39
cobenash#37 works for me.
Drupal 8.6.10
Panels 8.x-4.3
Ctools 8.x-3.2
Comment #40
iyyappan.govindHi @cobenash,
Thanks for the testing.
Comment #41
PunamShelkeWorks for me as well
Comment #42
PunamShelkeComment #43
MaxMendez CreditAttribution: MaxMendez commentedWorks as well, thanks.
Comment #44
proweb.ua CreditAttribution: proweb.ua commented#37 works
Comment #45
iyyappan.govindThanking you all for the testing.
Comment #46
pyxio CreditAttribution: pyxio commentedis this patch still needed with release of new ctools https://www.drupal.org/node/3033634
Comment #47
markdc#37 works, thanks.
Comment #48
YurkinPark CreditAttribution: YurkinPark at Skilld commentedConfirm, patch from #37 is good solution. Tested on same instance like described in #39.
Comment #49
iyyappan.govind@pyxio
Yes we need this patch to be included. Thanks
Comment #50
manuel.adantests/src/Unit/panels_ipe/RequestHandlerTestBase.php:9
Some references to old \Drupal\user\TempStoreException, moved to \Drupal\Core\TempStore\TempStoreException:
panels_ipe/src/Controller/PanelsIPEPageController.php:137: * @throws \Drupal\user\TempStoreException
panels_ipe/src/Helpers/RequestHandlerBase.php:100: * @throws \Drupal\user\TempStoreException
panels_ipe/src/Helpers/RequestHandlerBase.php:113: * @throws \Drupal\user\TempStoreException
panels_ipe/src/Helpers/RequestHandlerBase.php:124: * @throws \Drupal\user\TempStoreException
Not mandatory but recommended to fix CS in updated lines. In this case, missing property description in PHPDoc.
Comment #51
YurkinPark CreditAttribution: YurkinPark at Skilld commentedFixes are implemented
Comment #52
iyyappan.govind@YurkinPark
Thanks for test fix.
Comment #53
thallesThanks!
Works fine!
Comment #54
iyyappan.govindHi @thalles
Thanks for your test and screenshot.
Comment #55
andrewkamm CreditAttribution: andrewkamm commentedI'm rolling back CTools to work around this, but is there any word on when a new release will be issued that includes the reviewed and tested fixes above?
Comment #56
rafiqasad CreditAttribution: rafiqasad commented#51 works for me,
Thanks
Comment #57
xeM8VfDh CreditAttribution: xeM8VfDh commentedI have the same questionas @andrewkamm... since this fix has been verified by multiple users, and this is a crucial problem, can we get an update as to when this fix be released? Seems we haven't had a panels release since April 14 2018, so we're long overdue.
Comment #58
manuel.adanMy personal recommendation is not to update the ctools module and any other module that depends on it until a stable release of all of them were launched.
To do so, if you are using composer for your project:
Comment #59
binnythomas CreditAttribution: binnythomas commentedPatch #51 is working for me. I was working on setting up Varbase Dashboard when I ran into the error when trying to get the panel layout changed.
Comment #60
ifrikPatch #51 works for me for Drupal 8.6
Comment #61
thallesHi everyone, why not commit this patch?
It is likely that it will be of great help.
Comment #62
xeM8VfDh CreditAttribution: xeM8VfDh commentedAgreed, commit and publish a new release (assuming Page Manager gets on board and releases their related patch as well)
Comment #64
japerryComment #66
tdnshah CreditAttribution: tdnshah commentedI am using acquia's lighting profile and facing the same issue below are the version of the modules I have :-
1. Ctools - 8.x-3.0
2. Page Manager andd page manager UI - 8.x-4.0-beta3
3. Panels - 8.x-4.4
In my console I am getting an AJAX Error as below
I tired installing layout plugin module but even after enabling it, the problem didn't got resolved.
When I tried applying #51 patch but I get the message saying previously applied .
Comment #67
Oscaner CreditAttribution: Oscaner at CI&T commented