Page Manager currently not working with CTools 3.1+

Yes, page manager UI is also affected by #2936263: User's temp stores has been moved to core for 8.5.x, introduced in ctools 3.1

Yeah!! I get this problem too.

I attach quick fix.

I did the same work. I fix some CS in affected files and added dependency on core system >= 8.5. However, it wont work until #3033634: Replace user temp store service name by the core temp store in forms is solved in ctools.

#3 - #4 interdiff.

I have some problems on the Page access. After submission the plugin form nothing happens. But I found a cause.
https://www.drupal.org/node/2854819

$content['submit']['#attached']['drupalSettings']['ajax'][$content['submit']['#id']]['url'] = $url;

'url' was getting a string value but it gets a object now.
If set it as a string value then settings are submitted. BUT! redirect url will be is wrong

Yes, that is another issue, I open a new issue in ctools issue queue for it: #3033651: AJAX forms broken after URL refactoring, string expected instead of object

Yes! It's work now..
wow!! My weekend time was spent to solve these problems. I am disappointed

Fix failed testing.

Thanks Jian for helping, you are first
still one test .. not sure
Do we have messing fixes in the patch?
or should be a change in the test.

doTestAddVariant

fail: [Other] Line 301 of modules/contrib/page_manager/page_manager_ui/src/Tests/PageManagerAdminTest.php:
Value 0 is identical to value 1.

So I guess this patch isn't production ready if it's still failing a test, right?

Drupal\page_manager_ui\Tests\PageManagerAdminTest->doTestAddVariant() test fails anyway without the patch and ctools 3.0, It seems to be related to the Drupal core version. Trying with Drupal 8.6 it pass.

Good to know @manuel.adan, thanks. Is it safe to patch production? Will the future updated release, whenever that comes out, simply overwrite the patch and install seamlessly?

Also, is what @skybow said in #9 true, that this patch must be applied to the 8.x-4.x-dev branch instead of the official 8.x-4.0-beta3 release branch? If so, and one already has 8.x-4.0-beta3 installed, are there any instructions anywhere for how to "update" to the dev branch?

Also, if it must be applied to the 8.x-4.x-dev branch, I'm wondering why a new beta branch isn't released to handle this. It looks like the beta branch hasn't been touched since April 13 2018, and the dev branch hasn't been touched since April 14th 2018, so I'm guessing they haven't diverged that much in that 1 day, and that the dev branch with this patch can be released as a new 8.x-4.0-beta4 branch. Is there any hope of that happening?

Is it safe to patch production?

Some other modules, like panels, are also affected by the latest ctools updates. From my point of view, for production environment it is better not to update the ctools module nor any other module that depends on it, keeping it in the 3.0 whenever possible.

I'm wondering why a new beta branch isn't released to handle this.

I just found #2960937: Replace usage of deprtecated SharedTempStore, dated on April'18 as well. It seems that current maintainers are busy. According to the projects page, it is in seeking co-maintainer(s) status, so I think there will be no new release soon.

thanks for the info @manuel.adan. The lack of commits for going on 1 year is slightly concerning. Hopefully some co-maintainers can be identified soon. Its such a popular module, I'd think many people would be invested in keep it up.

Also, the problem with your suggestions is that I and others have already updated Ctools.

I am facing the same issues. Trying to get Varbase Total Dashboard working and ran into an issue when changing the layout in Page Manager.

Patch #15 works for me with core 8.6 and Page Manager 4.0-beta3.

Failing test not related to this patch (see #19)

Verified in #24

Thankfully Panels has released their related patch.

@japerry (or another maintainer), would you mind releasing patch #15 above to finish this up? Would greatly appreciate it :)

All this is too complicated.
I have Ctools 3.2 and Page Manager seems to work properly in most cases. Does it mean that Page Manager is compatible with Ctools 3.2 or not? Can anybody please elaborate on this? Do I need to apply this patch if I use Ctools 3.2?

I update the title of the issue as it seems applicable to Ctools 3.2 either.

I applied the patch from #15 and things are looking up. I can now reorder variants (see #3044231: Variant weights are not saved) and delete them as well (see #3037225: Call to a member function getVariant() on null )

Thanks for the patches! this is fixed :-D

Thanks for the commit japerry! Any change for a new release to include this commit?