CommentFileSizeAuthor
#2 ctools-replaced_deprecated_url_method-2854819-2.patch8.14 KBbkhandruk

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
StatusFileSize
new ctools-replaced_deprecated_url_method-2854819-2.patch8.14 KB
andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Needs review » Reviewed & tested by the community

Changes are still relevant. I have checked the patch.

  • joelpittet committed 7511669 on 8.x-3.x authored by rocket.man 
    Issue #2854819 by rocket.man, andrey.troeglazov: Replace deprecated url...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks @rocket.man and @andrey.troeglazov, I've committed this to the dev branch.

manuel.adan’s picture

manuel.adan
Location 🌌
commented 
+++ b/src/Form/RelationshipConfigure.php
@@ -115,7 +116,8 @@ abstract class RelationshipConfigure extends FormBase {
-    $response->addCommand(new RedirectCommand($this->url($route_name, $route_parameters)));
+    $url = Url::fromRoute($route_name, $route_parameters);
+    $response->addCommand(new RedirectCommand($url));

The deprecated Drupal\Core\Routing\UrlGeneratorTrait::url returns a string. After the patch, Url object is assigned instead, so it fails everywhere.

Since this was committed, I opened a new issue for this, #3033651: AJAX forms broken after URL refactoring, string expected instead of object

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.