Problem/Motivation

Now all tags is been shown whether tag has content attached or not.

Proposed resolution

Show only tags which has attached contents.

CommentFileSizeAuthor
#11 remove_orphan_tags-2822321-11.patch1.33 KBdishabhadra
#9 interdiff_4-9.txt1.08 KBdhruveshdtripathi
#9 show_only_tags_which_has_attached_content-2822321-9.patch1.47 KBdhruveshdtripathi
#4 show_only_tags_which_has_attached_content-2822321-4.patch1.5 KBpadma28

Issue fork dynamictagclouds-2822321

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    manojapare created an issue. See original summary.

    dishabhadra’s picture

    dishabhadra commented
    Assigned: Unassigned » dishabhadra
    padma28’s picture

    padma28 commented
    Assigned: dishabhadra » padma28
    padma28’s picture

    padma28 commented
    StatusFileSize
    new show_only_tags_which_has_attached_content-2822321-4.patch1.5 KB

    Added patch for show only tags which has attached contents. Please review.
    Thanks.

    padma28’s picture

    padma28 commented
    Status: Active » Needs review
    nkoporec’s picture

    nkoporec
    Primary language English
    Location Slovenia
    commented

    Hi @padma28, tested the patch and it's working as expected.

    nkoporec’s picture

    nkoporec
    Primary language English
    Location Slovenia
    commented
    Status: Needs review » Reviewed & tested by the community
    manojapare’s picture

    manojapare commented
    Status: Reviewed & tested by the community » Needs work

    @padma28

    Please find review feedback:

    1. In single line itself we can write select statement, instead creating a unneccessary variable DB connection object. Since we are using it in multiple places. Like
      \Drupal::database()->select('taxonomy_index', 'ti');
    2. PHPCS: Expected 1 space after IF keyword.

    Also, it would be better to keep one configuration check box to exclude orphan tags based on taxonomy_index table data.

    dhruveshdtripathi’s picture

    dhruveshdtripathi commented
    Assigned: padma28 » Unassigned
    Status: Needs work » Needs review
    StatusFileSize
    new show_only_tags_which_has_attached_content-2822321-9.patch1.47 KB
    new interdiff_4-9.txt1.08 KB

    Made changes suggested in comment #8

    Please review.

    Thanks!

    manojapare’s picture

    manojapare commented
    Status: Needs review » Needs work

    Patch is missing configuration to exclude orphan tags.

    dishabhadra’s picture

    dishabhadra commented
    Status: Needs work » Needs review
    StatusFileSize
    new remove_orphan_tags-2822321-11.patch1.33 KB

    I added patch to remove the terms with are not attached with any node content.

    I am checking node status as well. If it's status is unpublished then not listing that term.

    Kindly review my patch.

    manojapare’s picture

    manojapare commented
    Status: Needs review » Needs work

    @dishabhadra

    Thanks for the patch. It looks fine.

    But from taxonomy index table we get only taxonomies associated with nodes. What if the user wants tag cloud attached to any entity like file entity.

    In this case, we need one configuration where the user can select exclude orphan tags.

    manojapare’s picture

    manojapare commented

    Need to re roll the patch based on #2953492: Make use of Plugin Manager for extending tag cloud styles

    dishabhadra’s picture

    dishabhadra commented
    Assigned: Unassigned » dishabhadra
    manojapare’s picture

    manojapare commented
    Assigned: dishabhadra » Unassigned