Hello!
Suggestion: why not use the medium breakpoint instead of the large in zurb_foundation.theme lines 294-309?
I believe that there is still room for having the sidebars aside of the main content on let's say an iPad in portrait orientation, now they are pushed down below the main, just as on a smartphone. That's because the large breakpoint is used. Here is the code with the medium replacing the large.
if (!empty($left) && !empty($right)) {
$variables['main_grid'] = 'medium-6 medium-push-3';
$variables['sidebar_first_grid'] = 'medium-3 medium-pull-6';
$variables['sidebar_sec_grid'] = 'medium-3';
}
elseif (empty($left) && !empty($right)) {
$variables['main_grid'] = 'medium-9';
$variables['sidebar_first_grid'] = '';
$variables['sidebar_sec_grid'] = 'medium-3';
}
elseif (!empty($left) && empty($right)) {
$variables['main_grid'] = 'medium-9 medium-push-3';
$variables['sidebar_first_grid'] = 'medium-3 medium-pull-9';
$variables['sidebar_sec_grid'] = '';
}
else {
$variables['main_grid'] = 'medium-12';
$variables['sidebar_first_grid'] = '';
$variables['sidebar_sec_grid'] = '';
}
For me is was a bit hard to find that here is where I could change this behaviour.
Thanks for a great base theme!
Comments
Comment #2
bandanasharma commentedCreated patch for this. Also attached the interdiff file.
Comment #3
samuel.mortensonComment #4
serg2 commentedThe patch still applies against the dev and is a sensible change.
Comment #5
hongpong commentedIn my experience this is a good idea and I am inclined to commit it, unless there are objections.
Comment #6
serg2 commentedThis patch makes the theme more responsive and is a good change. There have not been any objections so lets roll it in before the stable :)
Comment #8
hongpong commentedGood call. Thanks bandanasharma and serg2, it is now in 8.x-6.x . I do not think it should be put on 8.x-5.x because that is already in beta and it would be a breaking change, but I would be open to a counter argument if needed.