NAB Transact integration for Payment module

Sandbox project: https://www.drupal.org/sandbox/joppy/2821328

Git clone:

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/joppy/2821328.git nab_transact_payment
cd nab_transact_payment

Comments

joppy created an issue. See original summary.

PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

visabhishek’s picture

Title: D7 NAB Transact Payment » [D7] NAB Transact Payment
Issue summary: View changes
scott.allison’s picture

Status: Needs review » Needs work

1. Please add documentation for the variables for each method inside the NabTransactPaymentPaymentMethodController class.

2. Inside public function loadTransaction() on line 186 of NabTransactPaymentPaymentMethodController.inc: you do not need to specify every column in your db_query(). If the schema changes in the future, you may need to make changes in more than one location. Simply change line 186 to:
$query->fields('ntp')

3. Add additional details to your sandbox project. Here is a template to help: https://www.drupal.org/docs/develop/documenting-your-project/project-pag...

4. With any module, but especially when processing payments, it may be a good idea to write unit tests. I recommend creating unit tests for this project. More details: https://www.drupal.org/docs/7/testing/unit-testing-with-simpletest

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.