Display resize icon for CKEditor on Seven theme

That was easy, thanks @altrugon !
Patches should be against dev, and since there were no changes in that file, the patch should apply.

Thanks @altrugon. What would be the easiest way to implement this temporarily, until the patch is incorporated? Perhaps inserting the style via a custom module?

So this was introduced in #2090937: Seven theme: style CKEditor-native dialogs to match Drupal-native dialogs and - I assume - that specific styling was meant to disable the resize icon on dialogs (see the screenshots in that issue). So someone needs to test that that in fact does not re-appear with this patch. Setting back to needs review for that.

...that specific styling was meant to disable the resize icon on dialogs...

That is correct!

Since #2239419: Include CKEditor's AutoGrow plug-in removed resize but only since 8.3.x, I propose to make the .cke_reset_all .cke_resizer selector more specific for 8.2.x which won't cause any regression afterwards.

Moving this to the ckeditor issue queue where it actually belongs and setting back to NW.

@altrugon This issue is about #2090937: Seven theme: style CKEditor-native dialogs to match Drupal-native dialogs causing the resize icon to be hidden not only for the dialogs but also for the ckeditor itself. This affects only 8.2.x since #2239419: Include CKEditor's AutoGrow plug-in removed the resize plugin in favor of the autogrow.

I propose to make the .cke_reset_all .cke_resizer selector more specific for 8.2.x which won't cause any regression afterwards.

Also please don't RTBC an issue with your own patch. I have pinged Wim Leers (the maintainer of ckeditor.module) to give feedback. Setting back to NR and to it's proper component.

Thanks for sharing your solution @altrugon. I have now added it to my make file. If any else also want to apply the patch in a make file, here is how:

# Core project
projects:
  drupal:
    version: ~
    patch:
      - "https://www.drupal.org/files/issues/drupal-seven-theme-display-resize-ckeditor-icon-2820200-1.patch"

#2090937: Seven theme: style CKEditor-native dialogs to match Drupal-native dialogs was in the Seven theme component, so then this should also be.

This should be reviewed by people closely involved in that issue. Left a comment there pointing to this issue.

Ughhh I just spent a lot of time on this. At first I thought the resize plugin was simply not shipped with our version of CKEditor since the icon was not there and because there's no "resize" plugin folder in core/assets/vendor/ckeditor/plguins/, but apparently when you download an optimized version of CKEditor it adds in the plugin files to the main JS file if it can. I tried creating my own plugin integration to add it which of course was not working because it's actually already registered.

Here's a patch that makes the selector more specific to the dialog box, which I'm sure is what was actually intended.

I wonder if it's appropriate to bump this to major since it affects user experience so dramatically? The default window height for the editor is so small and it's infuriating being unable to resize it.

Thank you @bkosborne!!

+1 for #18 from me as it addresses the issue I mentioned at #11 and #13 and therefore could go at RTBC. Attaching screenshots from the manual testing I did which correctly shows the icon at the CKEditor body instance but not at the dialog.

One nit I propose is a to add a todo to remove this css rule when 8.3.x is shipped as it won't have the resize plugin per #2239419: Include CKEditor's AutoGrow plug-in

I can also confirm that this patch solves the problem at hand. Let's get this in fast, saving hours of frustration for site builders.

This looks like a very sane solution.

We can't add tests; Drupal core needs visual regression testing to catch this.

rtbc +1

PS: bartik already works fine

Another x minutes wasted by the team here as we all pointed fingers and tried to remember the last time we saw it, or was it always like this in D8, or has it been made optional somewhere, or are we all just going mad...

Thanks for the fixes, thanks @altrugon . Putting it into our composer.json for now, I guess :-}

It would be really great if this patch could get included in 8.2.3, if that's possible.

That's just an unrelated testbot infra fail by the looks of things.
Leave this RTBC.

Committed and pushed 892272e to 8.3.x and c10b035 to 8.2.x. Thanks!

i have no resize icon in Drupal 8.3.1 and 8.3.2 Whats wrong with the commit?

My initial thought as well, but at least the CKEditor plugin Auto Grow is now active. Try to add a lot of text in the Body field, and you should see it expand accordingly. Not sure if the resize icon will ever return ...

Hi ressa,

yeah i know but the icon should appear too because after a long text the max. height of the editor is reached and the autogrow stops ;-/

We also need it usually when toggling to "source". That css is still there but does nothing whether deleted or present.

This must have happened with an update to ckeditor, although it looks like the public ckeditor does still have the resize icon.

I for one, want it back, but perhaps this should be a new issue.

is there a solution or a new issue in the meanwhile?

This commit http://cgit.drupalcode.org/drupal/commit/?id=892272e at #28 didn't fix the issue, it simple hid something else. Please

I accept on face value that autogrow not working is a separate bug (I'm seeing the same issue at #32), but we do still need the resize for "source" etc.

Update, fresh install, autogrow is working for me, so I've created this issue for the "source" mode problem.
https://www.drupal.org/node/2901137

Somehow I do not get it. I now have many big body texts to scroll for ages because there is no option no more to limit the vertical view of the input field. This is a nightmare... How to enable rezise and count of rows to show for body text now?

How to enable ... count of rows to show for body text now?

I opened an issue for that: #2996315: Set autogrow_minHeight to the height of the textarea.