JavaScript is sometimes "Javascript", which is not correct.

CommentFileSizeAuthor
#45 2819245-rerolled-45.patch25.38 KBVidushi Mehta
#37 interdiff_34-37.txt1.78 KBnarendra.rajwar27
#37 2819245-37.patch25.38 KBnarendra.rajwar27
#34 doc-change-javascript-2819245-33.patch22.99 KBdavidhernandez
#32 typo_in_copyright-2819245-32.patch21.97 KBmayurjadhav
#31 typo_in_copyright-2819245-31.patch38.09 KBmayurjadhav
#24 2819245-24.patch21.98 KBakashkumar07
#17 Javascript_should_be_JavaScript.patch23.38 KBPatashINotFound
#8 Javascript_should_be_JavaScript-2819245-8.patch9.13 KBvagelis-prokopiou
#4 Javascript_should_be_JavaScript-2819245-4.patch162.84 KBvagelis-prokopiou
#2 typo_in_copyright-2819245-1.patch391 bytesvagelis-prokopiou

Comments

Vagelis created an issue. See original summary.

vagelis-prokopiou’s picture

vagelis-prokopiou commented
Status: Active » Needs review
StatusFileSize
new typo_in_copyright-2819245-1.patch391 bytes

Here is the patch.

cilefen’s picture

cilefen commented
Title: Typo in core/COPYRIGHT.txt » "Javascript" should be "JavaScript"
Version: 8.2.x-dev » 8.3.x-dev
Issue summary: View changes
Status: Needs review » Needs work

This is an ok idea but it would be better scoped as a general fix. Note that many class names contain "Javascript" because that is the convention.

vagelis-prokopiou’s picture

vagelis-prokopiou commented
Status: Needs work » Needs review
StatusFileSize
new Javascript_should_be_JavaScript-2819245-4.patch162.84 KB

I don't know how helpful this is, but I have broadened the "scope".
I submit a patch that handles all instances of "Javascript" whether within a file, or within a file or directory name.
I run this against the current stable version and it worked like a charm.
Do comment with suggestions.

cilefen’s picture

cilefen commented
Status: Needs review » Needs work

You renamed classes. Please don't do that! See #3.

vagelis-prokopiou’s picture

vagelis-prokopiou commented

Ok. I understand.
But what does "general fix" mean?
I have read the links you provided but did not fully comprehend everything. So, sorry for that.
All occurrences apart from code occurrences? Because if that is true, then, I did not find any other occurrence of "Javascript".
I will double check that, though.

cilefen’s picture

cilefen commented

Comment and strings are fine. It must remain "Javascript" in class names.

vagelis-prokopiou’s picture

vagelis-prokopiou commented
StatusFileSize
new Javascript_should_be_JavaScript-2819245-8.patch9.13 KB

Patch that updates "Javascript" to "JavaScript", in all comments and strings.

vagelis-prokopiou’s picture

vagelis-prokopiou commented
Status: Needs work » Needs review

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

PatashINotFound’s picture

PatashINotFound commented
Issue tags: +ContributionWeekend2019
PatashINotFound’s picture

PatashINotFound commented
Assigned: Unassigned » PatashINotFound
Status: Needs review » Needs work

Needs work as couldn't apply the patch for given version.

PatashINotFound’s picture

PatashINotFound commented
StatusFileSize
new Javascript_should_be_JavaScript.patch23.38 KB

Ported the patch for 8.8.x

PatashINotFound’s picture

PatashINotFound commented
Status: Needs work » Needs review
PatashINotFound’s picture

PatashINotFound commented
Assigned: PatashINotFound » Unassigned

un-assigning myself as the patch is added.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs review » Reviewed & tested by the community

Hello

I've reviewed the patch #17 Javascript_should_be_JavaScript.patch .
Patch applied correctly. Fixes look/work well for me. +1 RTBC.

also, @vagelis-prokopiou can you use the next time the Issue Summary Template?

cilefen’s picture

cilefen commented

How will we prevent “Javascript” in strings? See #3051548-8: Fix spelling of "email" for a similar case.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

We still have multiple instances of javascript that should be "JavaScript". I think it would be nice to get those fixed in the same issue.

akashkumar07’s picture

akashkumar07 commented
Assigned: Unassigned » akashkumar07
akashkumar07’s picture

akashkumar07 commented
Assigned: akashkumar07 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2819245-24.patch21.98 KB

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

capysara’s picture

capysara commented

Patch in #24 still applies to 8.9

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tripurari’s picture

tripurari commented

Need to rerolled according to new version 9.1.x-dev

tripurari’s picture

tripurari commented
Issue tags: +Needs reroll
mayurjadhav’s picture

mayurjadhav commented

Working on it, will update rerolled patch shortly.

mayurjadhav’s picture

mayurjadhav commented
StatusFileSize
new typo_in_copyright-2819245-31.patch38.09 KB

Rerolled the patch with 9.1.x branch, Please review.

mayurjadhav’s picture

mayurjadhav commented
StatusFileSize
new typo_in_copyright-2819245-32.patch21.97 KB

Accidentally uploaded wrong patch, Uploaded the rerolled the patch with 9.1.x branch, Please review.

Status: Needs review » Needs work

The last submitted patch, 32: typo_in_copyright-2819245-32.patch, failed testing. View results

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new doc-change-javascript-2819245-33.patch22.99 KB

Hash needs updating for the test.

Status: Needs review » Needs work

The last submitted patch, 34: doc-change-javascript-2819245-33.patch, failed testing. View results

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented

Working on failed tests.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 2819245-37.patch25.38 KB
new interdiff_34-37.txt1.78 KB

Adding patch for fixing test failure.

tripurari’s picture

tripurari commented
Assigned: Unassigned » tripurari

Assigning for Review, will update the status shortly

samiullah’s picture

samiullah commented
Assigned: tripurari » Unassigned

Looks. good
Checked the update in following files
patching file core/COPYRIGHT.txt
patching file core/misc/entity-form.es6.js
patching file core/modules/action/tests/src/FunctionalJavascript/ActionFormAjaxTest.php
patching file core/modules/book/book.es6.js
patching file core/modules/book/book.module
patching file core/modules/content_translation/src/FieldTranslationSynchronizer.php
patching file core/modules/media/js/form.es6.js
patching file core/modules/node/content_types.es6.js
patching file core/modules/node/node.es6.js
patching file core/modules/settings_tray/settings_tray.module
patching file core/modules/system/css/components/js.module.css
patching file core/modules/system/tests/modules/js_message_test/src/Controller/JSMessageTestController.php
patching file core/modules/system/tests/src/Functional/Routing/DestinationTest.php
patching file core/modules/views/config/schema/views.style.schema.yml
patching file core/modules/views/js/ajax_view.es6.js
patching file core/modules/views/src/Plugin/views/style/Table.php
patching file core/modules/views/templates/views-view.html.twig
patching file core/modules/views_ui/admin.inc
patching file core/profiles/demo_umami/themes/umami/templates/classy/views/views-view.html.twig
patching file core/tests/Drupal/FunctionalJavascriptTests/Dialog/DialogPositionTest.php
patching file core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php
patching file core/tests/Drupal/FunctionalJavascriptTests/JavascriptGetDrupalSettingsTest.php
patching file core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php
patching file core/tests/Drupal/FunctionalJavascriptTests/WebDriverWebAssert.php
patching file core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
patching file core/tests/Drupal/KernelTests/Core/Theme/ConfirmClassyCopiesTest.php
Hunk #1 succeeded at 841 (offset 1 line).
patching file core/tests/Drupal/Tests/Core/Security/RequestSanitizerTest.php
patching file core/themes/bartik/templates/classy/views/views-view.html.twig
patching file core/themes/claro/templates/classy/views/views-view.html.twig
patching file core/themes/classy/templates/views/views-view.html.twig
patching file core/themes/seven/templates/classy/views/views-view.html.twig
patching file core/themes/stable/css/system/components/js.module.css
patching file core/themes/stable/templates/views/views-view.html.twig

If further code review is not needed this can be moved to RTBC

akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Reviewed & tested by the community

LGTM. Moving to RTBC.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Would it be possible to add Javascript to cspell flag words? This way we could avoid making this typo again in the future.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

> Would it be possible to add Javascript to cspell flag words?

Unfortunately not, cspell is case insensitive by design at the moment, and needs work upstream to change this: https://github.com/streetsidesoftware/cspell/issues/73

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Issue tags: +Needs reroll
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

Feel free to move back to RTBC after reroll

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2819245-rerolled-45.patch25.38 KB

Added a rerolled patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: -Needs reroll
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 99bad7e and pushed to 9.1.x. Thanks!

  • catch committed 99b9ff8 on 9.1.x 
    Issue #2819245 by vagelis-prokopiou, mayurjadhav, narendra.rajwar27,...
catch’s picture

catch
he/him
Primary language English
commented
samiullah’s picture

samiullah commented

Latest patch #47 looks good
Needs code review before moving to RTBC

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.