Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
JavaScript is sometimes "Javascript", which is not correct.
Comment | File | Size | Author |
---|---|---|---|
#45 | 2819245-rerolled-45.patch | 25.38 KB | Vidushi Mehta |
#37 | interdiff_34-37.txt | 1.78 KB | narendra.rajwar27 |
#37 | 2819245-37.patch | 25.38 KB | narendra.rajwar27 |
#34 | doc-change-javascript-2819245-33.patch | 22.99 KB | davidhernandez |
#32 | typo_in_copyright-2819245-32.patch | 21.97 KB | mayurjadhav |
Comments
Comment #2
vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commentedHere is the patch.
Comment #3
cilefen CreditAttribution: cilefen commentedThis is an ok idea but it would be better scoped as a general fix. Note that many class names contain "Javascript" because that is the convention.
Comment #4
vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commentedI don't know how helpful this is, but I have broadened the "scope".
I submit a patch that handles all instances of "Javascript" whether within a file, or within a file or directory name.
I run this against the current stable version and it worked like a charm.
Do comment with suggestions.
Comment #5
cilefen CreditAttribution: cilefen commentedYou renamed classes. Please don't do that! See #3.
Comment #6
vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commentedOk. I understand.
But what does "general fix" mean?
I have read the links you provided but did not fully comprehend everything. So, sorry for that.
All occurrences apart from code occurrences? Because if that is true, then, I did not find any other occurrence of "Javascript".
I will double check that, though.
Comment #7
cilefen CreditAttribution: cilefen commentedComment and strings are fine. It must remain "Javascript" in class names.
Comment #8
vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commentedPatch that updates "Javascript" to "JavaScript", in all comments and strings.
Comment #9
vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commentedComment #15
PatashINotFound CreditAttribution: PatashINotFound commentedComment #16
PatashINotFound CreditAttribution: PatashINotFound commentedNeeds work as couldn't apply the patch for given version.
Comment #17
PatashINotFound CreditAttribution: PatashINotFound at Srijan | A Material+ Company commentedPorted the patch for 8.8.x
Comment #18
PatashINotFound CreditAttribution: PatashINotFound commentedComment #19
PatashINotFound CreditAttribution: PatashINotFound at Srijan | A Material+ Company commentedun-assigning myself as the patch is added.
Comment #20
i-trokhanenkoHello
I've reviewed the patch #17
Javascript_should_be_JavaScript.patch
.Patch applied correctly. Fixes look/work well for me. +1 RTBC.
also, @vagelis-prokopiou can you use the next time the Issue Summary Template?
Comment #21
cilefen CreditAttribution: cilefen commentedHow will we prevent “Javascript” in strings? See #3051548-8: Fix spelling of "email" for a similar case.
Comment #22
lauriiiWe still have multiple instances of javascript that should be "JavaScript". I think it would be nice to get those fixed in the same issue.
Comment #23
AkashKumar07 CreditAttribution: AkashKumar07 at OpenSense Labs commentedComment #24
AkashKumar07 CreditAttribution: AkashKumar07 at OpenSense Labs commentedComment #26
capysara CreditAttribution: capysara at Bounteous commentedPatch in #24 still applies to 8.9
Comment #28
tripurari CreditAttribution: tripurari commentedNeed to rerolled according to new version 9.1.x-dev
Comment #29
tripurari CreditAttribution: tripurari commentedComment #30
mayurjadhav CreditAttribution: mayurjadhav at Srijan | A Material+ Company commentedWorking on it, will update rerolled patch shortly.
Comment #31
mayurjadhav CreditAttribution: mayurjadhav at Srijan | A Material+ Company commentedRerolled the patch with 9.1.x branch, Please review.
Comment #32
mayurjadhav CreditAttribution: mayurjadhav at Srijan | A Material+ Company commentedAccidentally uploaded wrong patch, Uploaded the rerolled the patch with 9.1.x branch, Please review.
Comment #34
davidhernandezHash needs updating for the test.
Comment #36
narendra.rajwar27Working on failed tests.
Comment #37
narendra.rajwar27Adding patch for fixing test failure.
Comment #38
tripurari CreditAttribution: tripurari commentedAssigning for Review, will update the status shortly
Comment #39
samiullah CreditAttribution: samiullah at Salsa Digital commentedLooks. good
Checked the update in following files
patching file core/COPYRIGHT.txt
patching file core/misc/entity-form.es6.js
patching file core/modules/action/tests/src/FunctionalJavascript/ActionFormAjaxTest.php
patching file core/modules/book/book.es6.js
patching file core/modules/book/book.module
patching file core/modules/content_translation/src/FieldTranslationSynchronizer.php
patching file core/modules/media/js/form.es6.js
patching file core/modules/node/content_types.es6.js
patching file core/modules/node/node.es6.js
patching file core/modules/settings_tray/settings_tray.module
patching file core/modules/system/css/components/js.module.css
patching file core/modules/system/tests/modules/js_message_test/src/Controller/JSMessageTestController.php
patching file core/modules/system/tests/src/Functional/Routing/DestinationTest.php
patching file core/modules/views/config/schema/views.style.schema.yml
patching file core/modules/views/js/ajax_view.es6.js
patching file core/modules/views/src/Plugin/views/style/Table.php
patching file core/modules/views/templates/views-view.html.twig
patching file core/modules/views_ui/admin.inc
patching file core/profiles/demo_umami/themes/umami/templates/classy/views/views-view.html.twig
patching file core/tests/Drupal/FunctionalJavascriptTests/Dialog/DialogPositionTest.php
patching file core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php
patching file core/tests/Drupal/FunctionalJavascriptTests/JavascriptGetDrupalSettingsTest.php
patching file core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php
patching file core/tests/Drupal/FunctionalJavascriptTests/WebDriverWebAssert.php
patching file core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
patching file core/tests/Drupal/KernelTests/Core/Theme/ConfirmClassyCopiesTest.php
Hunk #1 succeeded at 841 (offset 1 line).
patching file core/tests/Drupal/Tests/Core/Security/RequestSanitizerTest.php
patching file core/themes/bartik/templates/classy/views/views-view.html.twig
patching file core/themes/claro/templates/classy/views/views-view.html.twig
patching file core/themes/classy/templates/views/views-view.html.twig
patching file core/themes/seven/templates/classy/views/views-view.html.twig
patching file core/themes/stable/css/system/components/js.module.css
patching file core/themes/stable/templates/views/views-view.html.twig
If further code review is not needed this can be moved to RTBC
Comment #40
AkashKumar07 CreditAttribution: AkashKumar07 at OpenSense Labs commentedLGTM. Moving to RTBC.
Comment #41
lauriiiWould it be possible to add Javascript to cspell flag words? This way we could avoid making this typo again in the future.
Comment #42
longwave> Would it be possible to add Javascript to cspell flag words?
Unfortunately not, cspell is case insensitive by design at the moment, and needs work upstream to change this: https://github.com/streetsidesoftware/cspell/issues/73
Comment #43
davidhernandezComment #44
lauriiiFeel free to move back to RTBC after reroll
Comment #45
Vidushi Mehta CreditAttribution: Vidushi Mehta at gai Technologies Pvt Ltd commentedAdded a rerolled patch.
Comment #46
longwaveComment #47
catchCommitted 99bad7e and pushed to 9.1.x. Thanks!
Comment #49
catchComment #50
samiullah CreditAttribution: samiullah at Salsa Digital commentedLatest patch #47 looks good
Needs code review before moving to RTBC