See:

https://www.drupal.org/psa-2016-003

#2816405: Warn admin users on site status report page if insecure webforms are found

#2816121: [meta] Is there anything webform can do to mitigate PSA-2016-003?

#2816303: File upload destination should be private files by default if available

Possible solutions

  • Add warning that is displayed when public file uploads are enabled.
  • Managed file upload directory should default to 'private'.
  • There should be a global setting that defaults to require all file uploads to be private.
  • If the private files directory is not setup block the managed_file element from being used.
  • Managed file element support may need to be optional
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Issue summary: View changes
jrockowitz’s picture

Title: Add warning when allowing users to upload files to public file system » Drupal file upload by anonymous or untrusted users into public file systems -- PSA-2016-003
Issue summary: View changes

  • jrockowitz committed 5cc33a8 on 2817535-anonymous-file-upload
    Issue #2817535: Drupal file upload by anonymous or untrusted users into...
jrockowitz’s picture

Status: Active » Needs review
FileSize
35.62 KB

Status: Needs review » Needs work

The last submitted patch, 5: drupal_file_upload_by-2817535-5.patch, failed testing.

  • jrockowitz committed b6f936b on 2817535-anonymous-file-upload
    Issue #2817535: Drupal file upload by anonymous or untrusted users into...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
38.79 KB
jrockowitz’s picture

Disable public file upload by default. (Existing installations will still have public files enabled)

Allow elements (including 'Managed File') to be disabled.

Add warning to element dialog when public file uploads are enabled and selected.

Add warning about enabling the private file uploads to Status page.

  • jrockowitz committed 5676d0c on 2817535-anonymous-file-upload
    Issue #2817535: Drupal file upload by anonymous or untrusted users into...

  • jrockowitz committed ad8205a on 8.x-1.x
    Issue #2817535 by jrockowitz: Drupal file upload by anonymous or...
jrockowitz’s picture

Issue summary: View changes
Status: Needs review » Fixed
cilefen’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.