This is causing fails on Drupal HEAD, #2813981: [PP-1] Drupal\Tests\Core\Database\UrlConversionTest failing on PHP 7. Quoting @alexpott:

I think it is great we've had forewarning of this and we should be testing occasionally (nightly) against the bleeding edge but PHP7 patch and branch testing should be against the latest released version.

We don't test on PHP HEAD for other PHP versions. Is this vestigial from before PHP 7's first release?

But #2813981: [PP-1] Drupal\Tests\Core\Database\UrlConversionTest failing on PHP 7 is scary because there has been a PHP issue open so alexpott's suggestion is interesting.

Suggestions:

  • Add a web-7-dev container as a copy of web-7.
  • Switch web-7 to PHP releases.
  • Run nightlies on web-7-dev. Can we do that without bloating the test environment options on drupal.org?

Comments

cilefen created an issue. See original summary.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Component: Testrunner Codebase » Environments

It's totally vestigial, from when drupal was exposing all kinds of php7 bugs.

Now that php7 has moved on to 7.1, I would agree that chasing the tip of 7.0 isnt ideal.

We just got some new things merged into dev today, and are working on a refactor that will make this easier to adapt to.

Ideally we do something simple with the php7 containers, like pick a release and call it done, knowing that we can add back in the web-7-dev stuff later.. Otherwise, it falls squarely in the middle of colliding with the work we are in the midst of.

Would that be acceptable?

cilefen’s picture

cilefen CreditAttribution: cilefen commented

That works for me. -dev can be a separate issue.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

So now 7.1 released and maybe a time to create -dev version?

cilefen’s picture

cilefen CreditAttribution: cilefen commented

@Mixologic Do you want separate issues for:

  • This one: switching to released versions of PHP 7 (sortof a bug).
  • The other thing: nightly tests on PHP 7.1-dev (and 7.0-dev? - this is what is done now)
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Project: DrupalCI: Test Runner » DrupalCI: Environments
Component: Environments » Code

Moved to DrupalCI Environments.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Component: Code » PHP Containers
Issue tags: +PHP 7.1
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Related issues: +#2609560: Base DCI containers off official containers

This is related to #2609560: Base DCI containers off official containers. Which should fix this issue, once completed.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Parent issue: » #2609560: Base DCI containers off official containers
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Active » Fixed

Both php 7.0 and 7.1 now run on stable versions, with options to test against 7.0.x and 7.1.x if necessary. The php 7 runs 7.0.14 and 7.1 runs 7.1.0 currently, and the plan is to continously upgrade those to their highest available patch version as they become available.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.