[PP-1] Drupal\Tests\Core\Database\UrlConversionTest failing on PHP 7

Our containers are built against the PHP-7.0 branch of php on github.

https://github.com/php/php-src/commits/PHP-7.0

This is the first occurance of a php7 test failing with this issue : https://www.drupal.org/node/2808317#comment-11673203

And every single php7 patch from that point forward all have the exact same fails.

There is an existing PHP bug at https://bugs.php.net/bug.php?id=71822.

Maybe we need to stay on the island and not use parse_url? Or maybe there's a scalable library out there already that could be included?

This is reproducible on PHP 7.0 HEAD in isolation:

core ((8.2.0) %)$ php --version
PHP 7.0.13-dev (cli) (built: Oct  7 2016 16:06:36) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.11, Copyright (c) 1999-2016, by Zend Technologies
core ((8.2.0) %)$ ../vendor/bin/phpunit --filter=UrlConversionTest
PHPUnit 4.8.27 by Sebastian Bergmann and contributors.

EE..........

Time: 3.62 seconds, Memory: 126.00Mb

There were 2 errors:

1) Drupal\Tests\Core\Database\UrlConversionTest::testDbUrltoConnectionConversion with data set #0 ('', 'mysql://test_user:test_pass@t...tabase', array('mysql', 'test_user', 'test_pass', 'test_host', 'test_database', '3306'))
InvalidArgumentException: Minimum requirement: driver://host/database

/Users/cjm/Sites/drupal8x/core/lib/Drupal/Core/Database/Database.php:460
/Users/cjm/Sites/drupal8x/core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php:21

2) Drupal\Tests\Core\Database\UrlConversionTest::testDbUrltoConnectionConversion with data set #1 ('/var/www/d8', 'sqlite://test_user:test_pass@...tabase', array('sqlite', 'test_user', 'test_pass', 'test_host', '/var/www/d8/test_database', 3306))
InvalidArgumentException: Minimum requirement: driver://host/database

/Users/cjm/Sites/drupal8x/core/lib/Drupal/Core/Database/Database.php:460
/Users/cjm/Sites/drupal8x/core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php:21

FAILURES!
Tests: 12, Assertions: 10, Errors: 2.

cilefen++

The tests catch a legitimate PHP bug in HEAD. This is a moving-on-with-our-lives patch.

How did I do that?

This is one way to work around it. Better regex trickery is needed though.

I think PathAliasTest may be affected too. Remember to add php 7 tests for the patch instead of 5.5.

I'm not sure that we should be creating criticals against an un-released version of PHP. I think it is great we've had forewarning of this and we should be testing occasionally (nightly) against the bleeding edge but PHP7 patch and branch testing should be against the latest released version.

Nevertheless, forget the workaround, but it seems sensible to test for all allowed credentials characters and null passwords. PathAliasTest has some more, probably better, characters. We could rescope this issue to just that.

@Mixologic How onerous would it be to switch to releases generally?

@alexpott: Because there will be fails, is this critical until CI is changed?

I opened #2814933: PHP 7 test runs should be on released versions on CI.

On further consideration and discussion with alexpott, this needs to remain critical and be postponed on #2814933: PHP 7 test runs should be on released versions. We are unlikely to implement our own parse_url(). We may like more test coverage but the existing test caught this one.

Has this been fixed in PHP? It doesn't seem to be happening anymore?

@alexpott: It looks like they reverted it: https://github.com/php/php-src/commit/1c468ee044289661c8c4118a0653222596...

So we can close this one. The issue about which PHP7 version we test on is still relevant.