Ensure that the existing tests for CTools can be used and enable automated tests for the 7.x-1.x branch.

CommentFileSizeAuthor
#5 ctools-n2808985-5.patch3.88 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Closed (duplicate)

There are tests already.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add tests to CTools » Ensure CTools 7.x-1.x tests run, enable automated tests
Issue summary: View changes
Status: Closed (duplicate) » Active

Refocusing the issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Critical
Parent issue: » #2785697: Plan for CTools 7.x-1.11 release

Lets make this a critical issue for the next release, I'll be happy to focus on fixing the existing tests once someone turns on the automated tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new ctools-n2808985-5.patch3.88 KB

This patch lets me run all tests successfully:

$ simpletest ctools

Drupal test run
---------------

Tests to be run:
- Keywords substitution (CtoolsContextKeywordsSubstitutionTestCase)
- CSS Tools tests (CtoolsCssTestCase)
- CTools export CRUD tests (CtoolsExportCrudTestCase)
- CTools math expression stack tests (CtoolsMathExpressionStackTestCase)
- CTools math expression tests (CtoolsMathExpressionTestCase)
- Ctools object cache storage (CtoolsObjectCache)
- Get plugin info (CtoolsPluginsGetInfoTestCase)

Test run started:
Saturday, October 8, 2016 - 11:03

Test summary
------------

Keywords substitution 8 passes, 0 fails, and 0 exceptions
CSS Tools tests 9 passes, 0 fails, and 0 exceptions
CTools export CRUD tests 27 passes, 0 fails, and 0 exceptions
CTools math expression stack tests 17 passes, 0 fails, and 0 exceptions
CTools math expression tests 36 passes, 0 fails, and 0 exceptions
Ctools object cache storage 9 passes, 0 fails, 0 exceptions, and 2 debug messages
Get plugin info 15 passes, 0 fails, and 0 exceptions

Test run duration: 5 min 18 sec

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2785697: Plan for CTools 7.x-1.11 release » #2819121: Plan for CTools 7.x-1.12 release

Bumping to the 1.12 release.

rivimey’s picture

rivimey
she/her
commented
Status: Needs review » Reviewed & tested by the community

[Note: drush cc all is required after applying patch.]

Tested, fine by me.

rivimey’s picture

rivimey
she/her
commented
Related issues: +#2827100: Improve test coverage and function docs

I have started in another issue to extend the test suite.
See https://www.drupal.org/node/2827100

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Committed and turned on automated tests.

  • japerry committed 2047a9b on 7.x-1.x authored by DamienMcKenna 
    Issue #2808985 by DamienMcKenna: Ensure CTools 7.x-1.x tests run, enable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.