Improve test coverage and function docs

I question the test coverage data in comment #8, but I'm happy to see the test coverage itself improve. Great work, rivimey!

Rerolled.

Some minor tidying up.

Darnit, the patch isn't applying anymore via testbot, even though it applies perfectly locally.

Fixed a typo in math_expression.test.

Minor fixes to object_cache.test, object_cache_unit.test and uuid.test.

Two PHP 5.3 -compatibility fixes.

The following error is being logged by the testbot:

PHP Fatal error: Call to undefined function ctools_include() in /var/www/html/sites/all/modules/ctools/tests/object_cache_unit.test on line 97

Why would it fail to enable the CTools module, which is where that function exists?

The exception thrown by uuid.test is:

Constant UUID_PATTERN already defined

Given it's wrapped around an if(!defined()) I'm not sure how this is possible. Argh.

The UUID handling had to be split up into two classes, otherwise it was failing when the UUID module was loaded.

Not sure what's going on, the tests run correctly locally.

Darnitall :-\ Not sure what's going on :(

Some minor tweaks, shouldn't make any difference.

Trying to disable the UUID tests for later.

Additional minor tweaks.

That "Call to undefined function ctools_include() in object_cache_unit.test on line 97" error is continuing to cause it to fail, not sure what is causing that.

Running the tests locally, here's where it's failing:

Fail      Other      object_cache_unit  118 CtoolsUnitObjectCachePlugins->testF
    The Export Cache plugin: has a clear function
Exception Notice     object_cache_unit   52 CtoolsUnitObjectCachePlugins->asser
    Undefined index: cache clear
Fail      Other      object_cache_unit  118 CtoolsUnitObjectCachePlugins->testF
    The Export Cache plugin: clear is executable

This is because Export UI doesn't have a 'cache clear" method.

This patch updates export_ui.inc with a @todo comment, and disables the assertions that were failing but clarifies the @todo to say that the API problem should be fixed.

... what?

00:00:47.798 Test summary
00:00:47.798 ------------
00:00:47.798
00:00:48.013 PHP Fatal error: Call to undefined function ctools_include() in /var/www/html/sites/all/modules/ctools/tests/object_cache_unit.test on line 99
00:00:48.015
00:00:48.015 Fatal error: Call to undefined function ctools_include() in /var/www/html/sites/all/modules/ctools/tests/object_cache_unit.test on line 99
00:00:48.017 UUID handing, without UUID module 0 passes, 0 fails, and 0 exceptions
00:00:48.018 UUID handing, with UUID module 0 passes, 0 fails, and 0 exceptions
00:00:48.203 FATAL CtoolsUUIDWithUUID: test runner returned a non-zero error code (255).
00:00:52.664 Keywords substitution 14 passes, 0 fails, and 0 exceptions
00:00:52.842 Get plugin info 15 passes, 0 fails, and 0 exceptions
00:00:52.873 Math expressions stack 17 passes, 0 fails, and 0 exceptions
00:00:53.176 Object cache storage (UI tests) 9 passes, 0 fails, and 0 exceptions
00:00:53.280 CSS cache 4 passes, 0 fails, and 0 exceptions
00:01:04.121 Page token processing 16 passes, 0 fails, and 0 exceptions
00:01:04.617 CSS Tools tests 16 passes, 0 fails, and 0 exceptions
00:01:04.768 Math expressions 36 passes, 0 fails, and 0 exceptions
00:01:19.522 Export CRUD 27 passes, 0 fails, and 0 exceptions

So it's still failing on "Call to undefined function ctools_include()" for the first line of testFindSimpleCachePlugin(), which makes no sense as ctools.module should be loaded by that point.

As for "FATAL CtoolsUUIDWithUUID: test runner returned a non-zero error code (255)." I have no idea.

Adding ctools as a dependency on each getInfo() definition.

Ok, talking in IRC the problem with object_cache_unit.test is that it uses DrupalUnitTestCase(), which can't install modules thus ctools_include() is never made available.

Great improvements!

We're not ready to add any dependencies on 'uuid' yet, so lets leave that for later.

Bumping to 1.13.

Fixed the comment on the testBuildInFunctions() method, which is where the whitespace error came from.

RTBC in my book ;)

Looks good to me. Committed.

Thanks for finally committing this, japerry. BTW the commit authorship should have gone to rivimey - would you mind reverting & recommitting it with that corrected?

Considering the disabled tests and the dependency on uuid which causes a chain in breaking 5.3 compatibility. I'm considering reverting this patch in parts (mostly the @todo parts).

#2942581: ctools.test breaks Feeds tests on PHP 5.3 because of short array syntax
#2783113: Using trait without PHP 5.4 requirement breaks Drupal CI of all modules that require UUID

+++ b/tests/css.test
@@ -1,65 +1,103 @@
+   * @todo Test  db-row-exist but file-not-exist case in ctools_css_retrieve().

+++ b/tests/object_cache_unit.test
@@ -0,0 +1,141 @@
+    // @todo Clear is required by the spec (cache.inc:40..48): but export_ui
...
+    // @todo Break is optional acc'd to spec but does anything implement it?
...
+    // @todo Finalize is optional so don't fail if not there??

+++ b/tests/uuid_with_uuid.test
@@ -0,0 +1,55 @@
+    // @todo Add UUID as a test dependency and then add comment out this line.
+    // $modules[] = 'uuid';
...
+  public function DISABLED_testMakeNewUUID() {
+    // drupal_get_filename will report even if the module is disabled.

+++ b/tests/uuid_without_uuid.test
@@ -0,0 +1,101 @@
+   * @todo Fix this so testbot doesn't fail.
...
+   * @todo Fix this so testbot doesn't fail.
...
+  public function DISABLED_testMakeNewUUIDRaw() {
...
+   * @todo Fix this so testbot doesn't fail.
...
+  public function DISABLED_testMakeNewUUIDWrapper() {
...
+   * @todo Fix this so testbot doesn't fail.

Snuck in @todos

Here's what I propose we revert.

I think it should be sufficient to just comment out the test cases and the test_dependency in ctools.info - locally at least run-tests.sh won't discover the tests if this is done. I'm not sure exactly if that's also true with the testbot.

One way to find out would be to commit this attached patch, THEN try to test CTools against PHP 5.3 and see if it works. If not, revert the patch.

(I'm testing against 5.4 here because patches are applied AFTER the dependencies are calculated, so PHP 5.3 tests will fail even if the patch is correct - that's what happened in #62. The 5.4 test will simply ensure the patch applies, nothing else.)

The tests aren't finished or working, I'd rather remove them. I don't want to leave @todo in production code, that can stay in the issue queue.

#62 was committed