fix drupal coding standards

These changes doesn't look like an automated fix using phpcbf, please add a phpcs file + execute phpcbf.

Some more code cleanup required.

Added the new patch i think it's helpful.

Please suggest how to fix coding standards in Javascript file use in drupal modules.

Please use a phpcr configuration file so we can automate those checks. When you fix a rule then, you could add those rules, see the latest commit I made:
http://drupalcode.org/maxlength/commit/?id=64fbed4

Fixed Drupal coding standards.

Could not apply patch #19. Applied new patch fixing all the drupal coding standards.
Please review.

Applying the patch failed for me with the latest version of 8.x-1.x

Here are the results,

Hunk #1 FAILED at 1.
Hunk #12 succeeded at 292 (offset 3 lines).
Hunk #13 succeeded at 304 (offset 3 lines).
Hunk #14 succeeded at 356 (offset 3 lines).
1 out of 14 hunks FAILED -- saving rejects to file js/maxlength.js.rej
patching file maxlength.services.yml
patching file src/WidgetSettings.php
patching file src/WidgetSettingsInterface.php

Working on this.

Resolved the coding standard issue and its successfully applying for 8.x-1.x version. Please review.

Hi Sourabh,

Thank you for working on this.

Excellent, the patch now applies cleanly for me too.

A few small notes,

1. Changing this comment to

   "Limits the number of characters in textfields and textareas and shows the.

   Amount of characters left."

   Introduces grammar issues. I think it should be left as is, unless you have another suggestion to minimize the character length per line while maintaining proper grammar and readability.

2. Let's reword "@todo: Check if all them work" to "@todo Check if they all work."
3. Why did you remove the "@param $cache" comment? It seems that might be helpful to keep in.

The rest looks good as far as I can tell, though I'll have another maintainer with more coding experience do a final pass.

Thanks again for working on this.

Thanks Cadewey.
I am working on this.

Hi Cadewey

I have fixed the first two suggestions provided by you but regarding the 3rd suggestion when I am trying to write the '@param $cache' it is generating some more PHPCS issues
Hook implementations should not duplicate @param documentation

So when I investigated it I have found that in the hook we don't need to define @param. Everything is already defined in the definition.

Could you please review it and let me know if I still need to add @param $cache?

Thanks

Sourabh,

This looks great. Thank you very much for working on this.

I'm marking it Reviewed and Tested by the Community. As mentioned before, a more senior developer will do one more review before committing it to the 8.x-1.x branch.

Unfortunately, 3 of 4 hunks now fail when attempting to apply this to the head of 2.0.x. I had it on my list to check for coding standards prior to the RC2 release, anyways. Will update this ticket with more info soon.

Clayton, I updated the codebase to reflect coding standards. Please review my merge request.

This looks good on my end. Marking RTBC.