Problem/Motivation

If the site is in a subdirectory like http://example.com/subdir/, then the links are generated as http://example.com/subdir/subdir/. The problem is in \Drupal\mimemail\Utility\MimeMailFormatHelper::mimeMailUrl which does not strip out the base path in all scenarios.

CommentFileSizeAuthor
#2 links_are_not_generated-2807649-2.patch912 byteshussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new links_are_not_generated-2807649-2.patch912 bytes

This probably fixes other bugs with base path as well. If we don't correctly filter out the trailing slash from base_path(), then there is an exception when generating the URL. I tested this change when both the site is in a subdirectory or in the docroot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2863019: [META] Plan for MimeMail 8.x-1.0 release

Looks good to go.

  • sgabe committed cfaed25 on 8.x-1.x authored by hussainweb 
    Issue #2807649 by hussainweb: Links are not generated correctly when...
sgabe’s picture

sgabe commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.