Follow-up to #2802485: SubmissionID as a counter for submissions for each form

Problem/Motivation

YamlFormSubmission::sid is not an accurate counter for tracking submissions.

Proposed resolution

Add serial column to YAML form submissions.

Remaining tasks

  • Add serial column to yamlform_submission table.
  • Add next_serial to YamlFormSettings Form.
  • Add code to set serial to \Drupal\yamlform\YamlFormSubmissionStorage::doSave
  • Update YamlFormSubmission::label() to use serial.
  • Update Results Download to use serial.
  • Update Submission List builder to show serial column as #.
  • Add hidden SID to Submission List builder.
  • Update export by range
  • Write update hook.

User interface changes

Serial value will be displayed instead of submission id (sid).

API changes

None

Data model changes

Serial (serial) column will be added to yamlform_submission table.

Development Notes

  • Branch Name: 2806911-add-serial-column-to-submissions
  • Commit message: Issue #2806911: Add serial column to YAML form submissions
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed 4e17f32 on 2806911-add-serial-column-to-submissions
    Issue #2806911: Add serial column to YAML form submissions
    
jrockowitz’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
14.95 KB

Status: Needs review » Needs work

The last submitted patch, 4: add_serial_column_to-2806911-4.patch, failed testing.

  • jrockowitz committed 1e5b17d on 2806911-add-serial-column-to-submissions
    Issue #2806911: Add serial column to YAML form submissions. Fix broken...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
22.81 KB

  • jrockowitz committed 2965273 on 2806911-add-serial-column-to-submissions
    Issue #2806911: Add serial column to YAML form submissions. Additional...
jrockowitz’s picture

  • jrockowitz committed 43ab535 on 8.x-1.x
    Issue #2806911: Add serial column to YAML form submissions
    
jrockowitz’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.