Moderation states with the same name is unclear ...

It would be good to get some of the other folks that helped review #2750365: Permissions: moderation states with the same name is unclear for user to assign to a role to chime in here as well.

Some code feedback.

1. +++ b/core/modules/content_moderation/src/Entity/EntityUniqueLabelTrait.php
   @@ -0,0 +1,37 @@
   + * Provides a trait for selecting providing unique labels.
   

   This is off a bit since this trait deals with unique and non-unique. Perhaps "Provides a trait for getting labels."

2. +++ b/core/modules/content_moderation/src/Entity/EntityUniqueLabelTrait.php
   @@ -0,0 +1,37 @@
   +  /**
   +   * {@inheritdoc}
   +   */
   ...
   +  /**
   +   * {@inheritdoc}
   +   */
   

   I'm not sure traits can use {@inheritdoc}...

3. +++ b/core/modules/content_moderation/src/Entity/EntityUniqueLabelTrait.php
   @@ -0,0 +1,37 @@
   +    foreach (static::loadMultiple() as $arg) {
   +      $label = $arg->label(FALSE);
   

   Tiny nitpick, how about something more specific than $arg?

4. +++ b/core/modules/content_moderation/src/Form/ModerationStateForm.php
   @@ -23,7 +23,7 @@ public function form(array $form, FormStateInterface $form_state) {
   +      '#default_value' => $moderation_state->label(FALSE),
   
   +++ b/core/modules/content_moderation/src/Form/ModerationStateTransitionForm.php
   @@ -61,7 +61,7 @@ public function form(array $form, FormStateInterface $form_state) {
   +      '#default_value' => $moderation_state_transition->label(FALSE),
   

   Let's add code comments clarifying why we don't need a unique label here.

5. +++ b/core/modules/content_moderation/src/ModerationStateTransitionListBuilder.php
   @@ -82,7 +82,7 @@ public function buildHeader() {
   +    $row['label'] = $entity->label(FALSE);
   
   +++ b/core/modules/content_moderation/src/Permissions.php
   @@ -28,7 +28,7 @@ public function transitionPermissions() {
   +          '%transition_name' => $transition->label(FALSE),
   

   And here too.

I think since displaying the machine name can be seen as unfriendly, perhaps this patch can be updated to only display the machine name if the site in question has duplicate labels?

Applied the patch #5 worked cleanly but cant see the machine name added. Do I need to Add moderation. Please see screenshot.

This is solved by #2779647: Add a workflow component, ui module, and implement it in content moderation

Better status given the issue linked in #23?