CommentFileSizeAuthor
#28 2797093-28.patch19.53 KBamanshukla6158
#22 coding-standard-fixes-update-2797093-22.patch144.56 KBjatingupta40
#21 Screenshot from 2022-07-20 23-40-13.png129.75 KBjatingupta40
#21 Screenshot from 2022-07-20 23-40-05.png132.85 KBjatingupta40
#21 Screenshot from 2022-07-20 23-17-14.png60.18 KBjatingupta40
#18 coding-standard-fixes-2797093-18.patch110.18 KBurvashi_vora
#15 captcha-n2797093-15.patch91.18 KBAndreas Hansson
#14 captcha-n2797093-14.patch91.47 KBAndreas Hansson
#12 captcha-n2797093-11.patch83.07 KBdamienmckenna
#12 captcha-n2797093-11.interdiff.txt12.82 KBdamienmckenna
#11 captcha-n2797093-10.patch78.68 KBdamienmckenna
#11 captcha-n2797093-10.interdiff.txt26 KBdamienmckenna
#10 fix_coding_standard-2797093-10.patch62.01 KByogeshmpawar
#5 interdiff.txt3.83 KBamit.drupal
#5 Fix_drupal_coding_standards_PHP_constants_2797093-5.patch11.81 KBamit.drupal
#2 Fix_drupal_coding_standards_PHP_constants_2797093-1.patch9.06 KBprince_kr

Issue fork captcha-2797093

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prince_zyxware created an issue. See original summary.

prince_kr’s picture

prince_kr commented
StatusFileSize
new Fix_drupal_coding_standards_PHP_constants_2797093-1.patch9.06 KB
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 7.x-1.3 » 7.x-1.x-dev
elachlan’s picture

elachlan commented
Status: Active » Needs work

This patch needs to be re-rolled.

amit.drupal’s picture

amit.drupal commented
StatusFileSize
new Fix_drupal_coding_standards_PHP_constants_2797093-5.patch11.81 KB
new interdiff.txt3.83 KB

Update new patch .

amit.drupal’s picture

amit.drupal commented
Status: Needs work » Needs review

The last submitted patch, 2: Fix_drupal_coding_standards_PHP_constants_2797093-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: Fix_drupal_coding_standards_PHP_constants_2797093-5.patch, failed testing.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix_coding_standard-2797093-10.patch62.01 KB

Fix Coding standard issues.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new captcha-n2797093-10.interdiff.txt26 KB
new captcha-n2797093-10.patch78.68 KB

A bunch of additional smaller tweaks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new captcha-n2797093-11.interdiff.txt12.82 KB
new captcha-n2797093-11.patch83.07 KB

Some more.

Status: Needs review » Needs work

The last submitted patch, 12: captcha-n2797093-11.patch, failed testing. View results

Andreas Hansson’s picture

Andreas Hansson commented
StatusFileSize
new captcha-n2797093-14.patch91.47 KB

Made a diff on latest D7 to get rid of all phpcs warnings.

Andreas Hansson’s picture

Andreas Hansson commented
StatusFileSize
new captcha-n2797093-15.patch91.18 KB

Second try, correct level.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora
Status: Needs work » Needs review

Hi @Andreas,

I will review your patch.

urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Needs work

Hi @Andreas,

Your patch applied cleanly, but there are some errors still left.

I will work on them.

Thanks

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
StatusFileSize
new coding-standard-fixes-2797093-18.patch110.18 KB

Hi,

Please review this patch.

Thanks

Status: Needs review » Needs work

The last submitted patch, 18: coding-standard-fixes-2797093-18.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review and will provide a new updated patch if needed.
Thanks

jatingupta40’s picture

jatingupta40 commented
StatusFileSize
new Screenshot from 2022-07-20 23-17-14.png60.18 KB
new Screenshot from 2022-07-20 23-40-05.png132.85 KB
new Screenshot from 2022-07-20 23-40-13.png129.75 KB

The code does get applied cleanly but has some whitespace issues and some other issues shown in the image added.
I Will work on it.
Thanks

jatingupta40’s picture

jatingupta40 commented
Assigned: jatingupta40 » Unassigned
Issue summary: View changes
StatusFileSize
new coding-standard-fixes-update-2797093-22.patch144.56 KB

Providing a patch that resolves the phpcs issues.
Please Review.
Thanks

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs work » Needs review

Thank you for the patch. FYI when you upload a patch please set the issue status to "Needs review" to start the testbot and let others know that there's something to review.

jatingupta40’s picture

jatingupta40 commented

Yes, sure @DamienMcKenna. I just forgot to do that this time.
Thanks for the feedback.

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Should be rerolled as merge request.

amanshukla6158’s picture

amanshukla6158 commented
Status: Needs work » Needs review
StatusFileSize
new 2797093-28.patch19.53 KB

I have added patch resolving coding standard issue, Please review once.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@amanshukla6158 thanks see #27

ravi.shankar made their first commit to this issue’s fork.

ravi.shankar opened merge request !55

urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Needs review

Setting it to Needs Review so the MR could be reviewed.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.