[D8] Liquid slider

Hi Graber,

Please see my comments below.

Automated Review

Best practice issues identified by pareview.sh.

http://pareview.sh/pareview/httpsgitdrupalorgsandboxgraber2729947git

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation.

Found similar module Views Slideshow Liquid Slider.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code.

Found external Liquid Slider jquery files within module repository.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. README file not found in repository.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No: List of security issues identified.

Found menu callback with 'access callback' => TRUE. Give proper permission for menu callbacks in hook_menu().

Coding style & Drupal API usage

1. liquid_library(): No need to append library path explicitly with file urls.
   found

   'js' => array(
         $path . '/js/jquery.easing.min.js' => array(),
         $path . '/js/jquery.touchSwipe.min.js' => array(),
         $path . '/js/jquery.liquid-slider.min.js' => array(),
         drupal_get_path('module', 'liquid') . '/library/liquid.js' => array()
       ),
       'css' => array(
         $path . '/css/liquid-slider.css' => array(),
         $path . '/css/animate.min.css' => array(),
       )

2. I installed this module and while configuring views getting error:
   

   The liquid slider style cannot be used with a pager. Disable the "Use pager" option for this display.

   I am using Views 3.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks,
ARUN AK

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2795077

Project 2: https://www.drupal.org/node/2796389

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.