This js error stopped javascript on my node forms.

I've found that it's a incompatibility with Omega. See issue here https://www.drupal.org/node/1998434 The theme removes the ajaxPageState property if misc/ajax.js isn't loaded. I think the fix here is to pass in our own theme property instead of using one from a totally unrelated system.

CommentFileSizeAuthor
#8 2794587-8.interdif-7-8.txt1.68 KBjonathan1055
#8 2794587-8.adding-theme-js-setting.patch2.43 KBjonathan1055
#7 2794587-7.adding-theme-js-setting.patch2.34 KBjonathan1055
#3 2794587-3-adding-theme-setting.patch2.34 KBsmithmilner

Comments

Donnyboypony created an issue. See original summary.

smithmilner’s picture

smithmilner commented
Issue summary: View changes
smithmilner’s picture

smithmilner commented
Status: Needs work » Needs review
StatusFileSize
new 2794587-3-adding-theme-setting.patch2.34 KB

Adding a patch that adds the current theme name as a js setting.

jonathan1055’s picture

jonathan1055 commented

Hi Donnyboypony,
Thanks for reporting this and for providing the patch. Yes I agree it does seem better for us to set the theme value in the module rather than reply on the existing ajax value. I think I used that originally because I saw that the value was available and thought it was guaranteed to exist.

To allow me to test this, what version of Omega theme are you using? There are five downloadable 7.x choices.

smithmilner’s picture

smithmilner commented

I specifically had the issue with omega-4.4

jonathan1055’s picture

jonathan1055 commented

Thanks. Downloaded 7.x-4.4 and have tried the base theme and also the 'ohm' demo theme but I cannot replicate the error.

The theme removes the ajaxPageState property if misc/ajax.js isn't loaded.

Do you know how I can recreate the conditions such that ajax.js is not loaded?

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new 2794587-7.adding-theme-js-setting.patch2.34 KB

Same changes as in #3 for re-test before commit.

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new 2794587-8.adding-theme-js-setting.patch2.43 KB
new 2794587-8.interdif-7-8.txt1.68 KB

Fix coding standard and name the new function to not look like a hook implementation.

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Committed. Thank you Donnyboypony, sorry this fell off my list for so long.

I am now trying to finish (or close) some 7.x issues in prep for the next release - see #2838067: Features and Fixes for Scheduler 7.x-1.6 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.