Add the ability to set a default payment method

working on this.

couldn't make it work. :(

i'll try

There is PR for this:
https://github.com/drupalcommerce/commerce/pull/655

- Create new route for set-default
- Build a controller for the route
- Add this to payment methods list operations
- Default by default for the first or unique user payment method
- Extend and update Payment method tests to include this functionality (both Entity and functional)
- Extend the payment method storage with loadMultipleByUser & loadDefaultByUser methods.

Not sure about the loadMultipleByUser & loadDefaultByUser methods implementations.
Maybe some extra properties should be involved.

Now that we have #2827144: Support multiple payment gateways on Checkout Payment information pane
we need to use the default payment method in the Payment information pane.

PR updated with a commit on this.

PR updated with a commit to fix travis errors.
Now we're green
Last commit fix the postSave make it default for anonymous: no need to check/set the default for anonymous.

Adding related issue, https://www.drupal.org/node/2860102, the getDefaultPaymentMethodOption doesn't check if gateway is avaialble.

PR "reroll"

Uploading a patch based on @vasike PR for patching sake.

Another patch for the sake of patching with a rebase of the current commerce based on the PR at https://github.com/drupalcommerce/commerce/pull/848 which is just a rebase of https://github.com/drupalcommerce/commerce/pull/655 by @vasike

+++ b/modules/payment/src/Plugin/Commerce/CheckoutPane/PaymentInformation.php
@@ -309,7 +309,18 @@ protected function getDefaultPaymentMethodOption(array $options) {
+        if (in_array($default_payment_method->id(), $option_ids)) {

This might cause Call to a member function id() on boolean in Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentInformation->getDefaultPaymentMethodOption() if the current user doesn't have any payment method. Note when testing my user did have a completed order though. The fix would be something like if ($default_payment_method && in_array($default_payment_method->id(), $option_ids))

Rerolled PR at https://github.com/drupalcommerce/commerce/pull/655 with latest commerce.

Adding an event to which is dispatched on post save about payment is default. I wasn't sure if this should be added on this patch or in a follow up issue. I will need the maintainer to let me know then we can go with the patch at #15 or if ok then we go with this one. Also leaving it to need work until we figure out why the test are not passing.

Just found out that I uploaded a wrong file for #15. Here is another one hopefully it will pass the tests now.

Oops uploaded wrong patch file.

Reroll the latest patch to the latest dev version

Rerolled against dev

Small fix to address when the order has a payment method attached but that payment method is not available in the options.

Attached a reroll against dev and the following changes:

• Removed the adding to cart changes as they're not related to the issue
• Cleaned up the mark as default controller for D9
• Changed the preSave / postSave default checks to match the Profile module
• Updated loadMultipleByUser and loadByUser to match Profile's so it brings in the default first so the preSave/postSave work
• Slight refactor on the code to select a default payment method if the one used is no longer available.
• Updated the test to use loadByUser() instead of loadDefaultByUser()

does not apply to commerce 2.x-dev

.

update the patch for Drupal 10 & commerce 2.x-dev version

Reroll the patch to the latest dev version

Here is the patch updated for Commerce 3.x

Can we get an MR that applies to 3.x so we can see if the tests are green? The latest patch includes unrelated changes to the CartManager too.

Also, PaymentMethod::postSave() should probably query payment methods that have the is_default flag set to TRUE, so we don't have to load all payment methods belonging to the user (not sure there is a risk of a customer having hundreds of payment methods but still.

Here is the patch for 3.x without changes to the CartManager.

Is is possible to open a merge request with the changes?

I rebased the MR, reviewed it, and provided necessary updates, including fixes to code and tests. The current test actually revealed an issue with the owner check, which is now corrected.

I left a quick comment for a minor change with the controller. (using $commerce_payment_method directly).

Pushed a commit addressing that, and merged the 3.x changes, let's see where we stand now.

Ok... tests aren't passing...

The following code looks wrong to me:

elseif (count($storage->loadMultipleByUser($this->getOwner())) == 1) {
      // Set as default if it is the only payment method for the user.
      $this->setDefault(TRUE);
      $this->save();
    }

This doesn't belong to the postSave() method, as this will resave a payment method that was just saved, this should be moved to the presave().

Added test coverage for the PaymentOptionsBuilder.

There are 2 things that should likely be addressed:
1) non-reusable payment methods should never be set as default.
2) deleting default payment method should make the next eligible payment method default

Both these points can be done as follow-up(s) and need some extra considerations.

@zaporylie: Thank you for wrapping this up! Merged!