Expose hard facet limit as a configurable option

in SearchApiString we need to change the 50 with a config value for each facet:

      // Set the options for the actual query.
      $options = &$query->getOptions();

      $options['search_api_facets'][$field_identifier] = array(
        'field' => $field_identifier,
        'limit' => 50,
        'operator' => $this->facet->getQueryOperator(),
        'min_count' => 0,
        'missing' => FALSE,
      );

I've attached a patch for hard limit configuration.

We need a test for this.

We discussed this at Drupalcon and figure that we can commit this after we have a test for this.

@Alienpruts had an actual issue with the limit of 50 over in #2815169: OR in facet always returns 50 results.

I'd say that makes this a very important issue.

+++ b/src/Form/FacetForm.php
@@ -373,6 +373,15 @@ public function form(array $form, FormStateInterface $form_state) {
+    $hard_limit_options = [3, 5, 10, 15, 20, 30, 40, 50, 75, 100];

I guess that also means we have to up the limit here. Let's add a couple of extra settings here; 250, 500. I don't think adding more is a good idea.

Adds an integration test and the additional config for more items.

This now has test-coverage, so removing the tag. Leaving this open for reviews.

I can confirm the hard limit has been exposed and tested it with some values on a 300+ result set. No problems found :) .

+++ b/src/Tests/IntegrationTest.php
@@ -601,6 +601,38 @@ class IntegrationTest extends WebTestBase {
+    $edit['facet_settings[hard_limit]'] = 3;
...
+    $this->assertText('Displaying 5 search results');

If we set a limit of 3, why are we still showing 5 search results?

We set the limit only for the facets, not for the actual results.

Can we add that as a comment to the test? It is a nit, so I'm going to move to RTBC and it can be fixed on commit or in a re-roll.

I just tested this with search_api_db backend, and it did not limit the facet item count.
This might be a search_api_db issue though, maybe related to #2809753: getFacets in search_api_db returns wrong resultset (not sure)

Is this also tested with core_search as backend? Would be nice to have test coverage for both

I haven't tested it with core search yet no. I'll try to write a test that does that this weekend.

Stopping for the day. didn't get the core test to work yet :(

This currently doesn't work for core search, and I don't think it'll be easy to do so. Let's add a description or only show this option for search api based queries on top of #12?

Back to NR.

Atm I can't apply this patch as it's conflicting with "hierarchical structures" in #2807333 which I'm using..

I'll see if I can test is later but since this is where the magic happens, I'm quite confident it will work:

-        'limit' => 50,
+        'limit' => $this->facet->getHardLimit(),

One thought though: I assume this won't scale for hard limit settings of 1000+?

Building a system with 500+ items per facet is a very big one, not sure if we can support that - as that'd probably be really really slow.
It's still possible doing a form-alter and adding more items in the dropdown in the UI.

Patch no longer applied.

Committed, thanks for the issues, patches and reviews.