Closed (fixed)
Project:
Facet API
Version:
7.x-1.x-dev
Component:
User interface (functionality)
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Jul 2010 at 13:06 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jpmckinney commentedComment #2
pwolanin commentedNeeds to be reworked for facet API module's UI
Comment #3
cpliakas commentedThere would have to be modification of the Facet API code to add the value to the dropdown, then there would have to be coordination with the Apache Solr module's query type plugins to support the -1 as an unlimited value.
Comment #4
cpliakas commentedChanging title to use Facet API nomenclature.
Comment #5
cpliakas commentedAdding "low hanging fruit" tag.
Comment #6
nkschaefer commentedI started looking at this, expecting to do a fair amount of work. I'm using Search API, though, and it looks like Search API and the Solr backend already work without hard limits on facets (they check if the facet hard limit is true, so either 0 or -1 should work for a "no limit" setting).
Based on what cpliakas said, I made the "no limit" setting == -1.
Here's a patch that adds the form option. Let me know if there's anything else I can help with.
Comment #7
nkschaefer commentedOops - don't know how that setting got changed.
Comment #8
cpliakas commentedHow this works is that the -1 is passed as the facet.limit parameter to Solr. Looking at the documentation page at http://wiki.apache.org/solr/SimpleFacetParameters#facet.limit, a negative value means unlimited results. Therefore it works exactly as expected. This does have a Solr assumption, however I would bet Search API is smart enough to handle this for all backends. Marking as RTBC.
Thanks for the contribution,
Chris
Comment #9
cpliakas commentedCommitted at 19d2b4b.