Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Aug 2016 at 17:37 UTC
Updated:
14 Sep 2016 at 22:24 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
dilipsingh02 commentedHi,
Please fixed the following error :
Comment #4
niyas commented@dilipsingh02
Is this information for .info file really needed being its Drupal 8 project? Anyway I added it.
Kindly check it :)
Comment #5
niyas commentedComment #6
dilipsingh02 commentedHi Niyas,
please set git Default branch on your project page.
https://www.drupal.org/node/2780793/edit/default-branch
Thanks
Comment #7
klausiSetting the git default branch alone is surely not an application blocker. Anything else that you found or should this be RTBC instead?
Comment #8
dilipsingh02 commentedHi,
I have try to clone the module using given command but only .info file is download.
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/Niyas/2780793.git
please check files and update the git.
Thanks
Comment #9
arun ak commentedFiles missing in git repository. Please commit files properly. For further information about how to manage project with git refer Maintaining a drupal.org project with Git.
Comment #10
joachim commentedWhat's the difference between this and https://www.drupal.org/project/php ?
Comment #11
niyas commentedSorry guys, I added all missed files. Kindly check it and correct me if I am wrong.
@joachim - I think php shortcode can be used to execute php scripts in any filter format enabled field instead of creating standalone php filter.
Comment #12
kamdanishit commentedComment #13
joachim commented> @joachim - I think php shortcode can be used to execute php scripts in any filter format enabled field instead of creating standalone php filter.
The PHP module adds a filter which you can use in any text format. Aren't you saying the same thing about PHP Shortcode?
Comment #14
niyas commented@kamdanishit Thanks for your comments. I fixed it. Please check.
@joachim If we use php filter in any wysiwyg editor enabled fields, it creates an issue since it breaks the php code even though we enabled php evaluator. It might work for the first time, but if you edit the field again and see the code, "<?php" replaced by
" <!--?php"I hope it can be avoided using php_shortcode module since the shortcode can be used regardless of plain html field or editor enabled.
Please take a look at the screenshot http://prnt.sc/c6uecn
Comment #15
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxNiyas2780793git
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #16
joachim commentedThat problem with wysiwyg sounds like a bug in the Php module, rather than something that requires a new separate project. Have you filed an issue for it?
Comment #17
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.