Problem/Motivation

When editing a content type's settings (admin/structure/types/manage/foo), the following error occurs:

TypeError: Argument 3 passed to Drupal\rabbit_hole\FormManglerService::addRabbitHoleOptionsToEntityForm() must be an instance of Drupal\rabbit_hole\FormStateInterface, instance of Drupal\Core\Form\FormState given.

Proposed resolution

This is due to a missing use statement in FormManglerService.php.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 typeerror-on-ct-settings-2780501-2.patch488 bytesdietr_ch

Comments

dietr_ch created an issue. See original summary.

dietr_ch’s picture

dietr_ch commented
Status: Active » Needs review
StatusFileSize
new typeerror-on-ct-settings-2780501-2.patch488 bytes
andy_read’s picture

andy_read commented
Status: Needs review » Reviewed & tested by the community

Thanks for reporting and submitting a patch, @dietr_ch.
I also hit this error this afternoon when I did a composer update, but adding your patch has fixed the problem.

peacog’s picture

peacog commented

+1 for the patch. It also fixes the error for Taxonomy RH settings

kevinquillen’s picture

kevinquillen commented

This absolutely needs to be committed. The module breaks Drupal content management without this fix.

kevinquillen’s picture

kevinquillen commented
Priority: Major » Critical
jecunningham2281’s picture

jecunningham2281 commented

I also had this issue when attempting to use rabbit hole with content types. Applying this patch resolved the issue for me. I recommend committing this patch.

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented

+1 for the patch working and being critical

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

+1

una_maria’s picture

una_maria commented

+1

becw’s picture

becw commented

Necessary, and works for me as well.

dddbbb’s picture

dddbbb commented

The patch in #2 works for me too.

tassilogroeper’s picture

tassilogroeper commented

+1 - already using it in production

johnpitcairn’s picture

johnpitcairn commented

Another vote for #2. A commit would be good.

Yoann Bellarosa’s picture

Yoann Bellarosa commented

+1, this patch worked for me too

ruslan piskarov’s picture

ruslan piskarov
he/him
Primary language Ukrainian
Location Kyiv, Ukraine
commented

The patch in #2 works for me too.

dylan donkersgoed’s picture

dylan donkersgoed commented
Status: Reviewed & tested by the community » Fixed

This has been committed. Sorry about the delay, turns out I wasn't subscribed to issues for this module so I just became aware of this when we ran into the issue today.

dylan donkersgoed’s picture

dylan donkersgoed commented
Status: Fixed » Closed (fixed)
kevinquillen’s picture

kevinquillen commented

Thanks!