Since upgrade to 7-x.2.13 I get an error warning on the homepage :
Warning : end() expects parameter 1 to be array, string given dans sharethis_sharethis_content_type_render() (ligne 26 dans /home/www.example.com/sites/all/modules/sharethis/plugins/content_types/sharet...).

CommentFileSizeAuthor
#9 end_expects_parameter-2774205-9.patch717 bytesgg24
#6 sharethis-mini.jpg39.63 KBkarlshea
#5 sharethis-end-debug.jpg92.39 KBkarlshea
#5 sharethis-end.jpg36.75 KBkarlshea
#3 sharethis_context_end-2774205-3.patch662 byteskarlshea

Comments

ehanuise created an issue. See original summary.

ehanuise’s picture

ehanuise commented

On further investigation, sharethis displays correctly and throws no erros on nodes.
The error only ahppens on the homepage, where I have the sharethis widged in a panel.
I have the error _and_ sharethis does not display in that panel.
No other errors in the log than the above warning.

I also get another error :
Notice : Undefined index: entity keys dans entity_extract_ids() (ligne 7901 dans /home/www.example.com/includes/common.inc).
Notice : Undefined index: entity keys dans entity_extract_ids() (ligne 7902 dans /home/www.example.com/includes/common.inc).

I thought it was unrelated, but if I create several instances of the sharethis widget in the panel, I get several instances of all three errors, so there is a link.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Version: 7.x-2.13 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new sharethis_context_end-2774205-3.patch662 bytes

The error in sharethis_sharethis_content_type_render() is from $entity_type = end($context[0]->type). That's always going to be a string, I don't know what the intention was there.

lomasr’s picture

lomasr commented

Cant reproduce the error on my local . Please attach a screenshot of error.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
StatusFileSize
new sharethis-end.jpg36.75 KB
new sharethis-end-debug.jpg92.39 KB

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
StatusFileSize
new sharethis-mini.jpg39.63 KB

It's inside a mini panel that's placed on the page through a block.

Although just this patch doesn't work either, the widget gets the wrong path. I think this page should really be a Panels override instead of a mini panel in a block, so it might not be a use case you're trying to support.

realgiucas’s picture

realgiucas commented

I got the same problem and error.
Is there a way tyo use sharethis in a panel page?

gg24’s picture

gg24 commented
Assigned: Unassigned » gg24
Issue summary: View changes
gg24’s picture

gg24 commented
StatusFileSize
new end_expects_parameter-2774205-9.patch717 bytes
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

The patch solves it!

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Patch (to be ported)

@gg24 patch works fine for me too. Thanks for your efforts.

  • purushotam.rai committed 95d2d1e on 7.x-2.x authored by gg24 
    Issue #2774205 by KarlShea, gg24, ehanuise, lomasr, realgiucas,...
purushotam.rai’s picture

purushotam.rai commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.