Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There's a lot of t()
used in DS plugins but DsFieldBase extends PluginBase
so to make pligins unittestable they should use $this->t()
instead of t()
Comment | File | Size | Author |
---|---|---|---|
#34 | interdiff-2771825-30-34.txt | 25.13 KB | minakshiPh |
#34 | fix-issue-2771825-34.patch | 4.9 KB | minakshiPh |
#30 | 2771825_30.patch | 30.92 KB | poornima.n |
#25 | interdiff-2771825-20-25.txt | 637 bytes | minakshiPh |
#25 | fix-issue-2771825-25.patch | 4.9 KB | minakshiPh |
Comments
Comment #2
chishah92 CreditAttribution: chishah92 at Blisstering Solutions commentedComment #3
chishah92 CreditAttribution: chishah92 at Blisstering Solutions commentedI cannot find any t() all over the module . Please Advice
~Chirag
Comment #4
miteshmapComment #5
miteshmap@andypost: As per the issue definition only replaced for plugins there are also some t() left in form dir. should we create a new issue for that or in the same one?
Comment #9
andypostYep, form usage better keep separate
Looks string translation should be injected
No string escape should be used after t()
Comment #10
sneha_surve CreditAttribution: sneha_surve at Iksula commentedComment #11
sneha_surve CreditAttribution: sneha_surve at Iksula commentedApplied patch as per said in #9.
Thanks.
Comment #12
sneha_surve CreditAttribution: sneha_surve at Iksula commentedComment #16
Nitin Shirole CreditAttribution: Nitin Shirole at Trigyn Technologies Ltd commentedHi,
Attached is updated patch for this issue. Can anyone please review the patch?
Thanks,
Nitin
Comment #20
shruti1803 CreditAttribution: shruti1803 at Iksula commentedComment #24
minakshiPh CreditAttribution: minakshiPh at Iksula commentedComment #25
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded new patch with minor changes
Kindly review.
Thanks!
Comment #29
minakshiPh CreditAttribution: minakshiPh at Iksula commentedTest has passed!
Kindly review.
Thanks!
Comment #30
poornima.n CreditAttribution: poornima.n as a volunteer and at gai Technologies Pvt Ltd commentedComment #34
minakshiPh CreditAttribution: minakshiPh at Iksula commentedAdded new patch with fix.
Kindly review.
Thanks!
Comment #36
aspilicious CreditAttribution: aspilicious commentedThnx!