There's a lot of t() used in DS plugins but DsFieldBase extends PluginBase so to make pligins unittestable they should use $this->t() instead of t()

CommentFileSizeAuthor
#34 interdiff-2771825-30-34.txt25.13 KBminakshiPh
#34 fix-issue-2771825-34.patch4.9 KBminakshiPh
#30 2771825_30.patch30.92 KBpoornima.n
#25 interdiff-2771825-20-25.txt637 bytesminakshiPh
#25 fix-issue-2771825-25.patch4.9 KBminakshiPh
#20 interdiff-2771825-16-20.txt48.06 KBshruti1803
#20 ds-2771825-20.patch5.68 KBshruti1803
#16 ds-2771825-16.patch58.03 KBNitin Shirole
#11 2771825-11.patch52.09 KBsneha_surve
#5 replace_usage_of_t_2771825-5.patch2.79 KBmiteshmap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Assigned: Unassigned » chishah92
chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented

I cannot find any t() all over the module . Please Advice

~Chirag

miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap as a volunteer commented
Assigned: chishah92 » miteshmap
miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap as a volunteer commented
Assigned: miteshmap » Unassigned
Status: Active » Needs review
FileSize
replace_usage_of_t_2771825-5.patch2.79 KB

@andypost: As per the issue definition only replaced for plugins there are also some t() left in form dir. should we create a new issue for that or in the same one?

Status: Needs review » Needs work

The last submitted patch, 5: replace_usage_of_t_2771825-5.patch, failed testing.

The last submitted patch, 5: replace_usage_of_t_2771825-5.patch, failed testing.

The last submitted patch, 5: replace_usage_of_t_2771825-5.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Yep, form usage better keep separate
Looks string translation should be injected
No string escape should be used after t()

sneha_surve’s picture

sneha_surve CreditAttribution: sneha_surve at Iksula commented
Assigned: Unassigned » sneha_surve
sneha_surve’s picture

sneha_surve CreditAttribution: sneha_surve at Iksula commented
FileSize
2771825-11.patch52.09 KB

Applied patch as per said in #9.
Thanks.

sneha_surve’s picture

sneha_surve CreditAttribution: sneha_surve at Iksula commented
Assigned: sneha_surve » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 11: 2771825-11.patch, failed testing.

The last submitted patch, 11: 2771825-11.patch, failed testing.

The last submitted patch, 11: 2771825-11.patch, failed testing.

Nitin Shirole’s picture

Nitin Shirole CreditAttribution: Nitin Shirole at Trigyn Technologies Ltd commented
Status: Needs work » Needs review
FileSize
ds-2771825-16.patch58.03 KB

Hi,

Attached is updated patch for this issue. Can anyone please review the patch?

Thanks,
Nitin

Status: Needs review » Needs work

The last submitted patch, 16: ds-2771825-16.patch, failed testing.

The last submitted patch, 16: ds-2771825-16.patch, failed testing.

The last submitted patch, 16: ds-2771825-16.patch, failed testing.

shruti1803’s picture

shruti1803 CreditAttribution: shruti1803 at Iksula commented
Status: Needs work » Needs review
FileSize
ds-2771825-20.patch5.68 KB
interdiff-2771825-16-20.txt48.06 KB

Status: Needs review » Needs work

The last submitted patch, 20: ds-2771825-20.patch, failed testing.

The last submitted patch, 20: ds-2771825-20.patch, failed testing.

The last submitted patch, 20: ds-2771825-20.patch, failed testing.

minakshiPh’s picture

minakshiPh CreditAttribution: minakshiPh at Iksula commented
Assigned: Unassigned » minakshiPh
minakshiPh’s picture

minakshiPh CreditAttribution: minakshiPh at Iksula commented
Assigned: minakshiPh » Unassigned
Status: Needs work » Needs review
FileSize
fix-issue-2771825-25.patch4.9 KB
interdiff-2771825-20-25.txt637 bytes

Added new patch with minor changes

Kindly review.
Thanks!

Status: Needs review » Needs work

The last submitted patch, 25: fix-issue-2771825-25.patch, failed testing.

The last submitted patch, 25: fix-issue-2771825-25.patch, failed testing.

The last submitted patch, 25: fix-issue-2771825-25.patch, failed testing.

minakshiPh’s picture

minakshiPh CreditAttribution: minakshiPh at Iksula commented
Status: Needs work » Needs review

Test has passed!

Kindly review.
Thanks!

poornima.n’s picture

poornima.n CreditAttribution: poornima.n as a volunteer and at gai Technologies Pvt Ltd commented
FileSize
2771825_30.patch30.92 KB

Status: Needs review » Needs work

The last submitted patch, 30: 2771825_30.patch, failed testing.

The last submitted patch, 30: 2771825_30.patch, failed testing.

The last submitted patch, 30: 2771825_30.patch, failed testing.

minakshiPh’s picture

minakshiPh CreditAttribution: minakshiPh at Iksula commented
Status: Needs work » Needs review
FileSize
fix-issue-2771825-34.patch4.9 KB
interdiff-2771825-30-34.txt25.13 KB

Added new patch with fix.

Kindly review.
Thanks!

  • aspilicious committed ab16e9b on 8.x-2.x authored by minakshiPh 
    Issue #2771825 by minakshiPh, shruti1803, sneha_surve, miteshmap, Nitin...
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Fixed

Thnx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.