As per coding standard documentation at https://www.drupal.org/coding-standards/docs#file, the @file docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#3 2761347-3.patch36.85 KBmark_fullmer
#2 2761347-2.patch17.01 KBvinay15

Comments

Vinay15 created an issue. See original summary.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Assigned: vinay15 » Unassigned
Status: Active » Needs review
StatusFileSize
new 2761347-2.patch17.01 KB

Removed @file docblock.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
StatusFileSize
new 2761347-3.patch36.85 KB

This observation is valid, but there are also a number of other very minor code syntax violations. Given this is pure syntax, I'm opting for a patch that fixes all of it at once, rather than targeting the specific violations. The attached patch builds on the removal of the @file doc comment with fixing primarily the following :

  • Full stop at end of comments
  • Separating concat operators
  • Removing unused Use statements
  • Remove whitespace on empty lines
  • Add comma after last item in an array
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2854752: Plan for Video Filter 8.x-1.0 release

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.