I am using Smartqueue Language and Rules to automatically add new nodes to their respective language subqueue. I found out that the action adds my nodes to all subqueues. I inspected the code in nodequeue.rules.inc and found two bugs.

First, the action checks for two smartqueues only, taxonomy and domain. It does not check for any other smartqueues installed.

Second, the action checks if any smartqueues (limited to taxonomy smartqueue) or domain smartqueue is not available to add the node to a subqueue on line 325, but the condition checks twice for domain smartqueue:
if (!$smartqueue_domain_enabled && !$smartqueue_domain_enabled){
which should be
if (!$smartqueue_enabled && !$smartqueue_domain_enabled)

CommentFileSizeAuthor
#2 nodequeue_final-check-for-subqueue-in-rules.patch946 bytesshadysamir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shadysamir created an issue. See original summary.

shadysamir’s picture

shadysamir CreditAttribution: shadysamir as a volunteer commented
Status: Active » Needs review
FileSize
nodequeue_final-check-for-subqueue-in-rules.patch946 bytes

Here is a patch for second issue

Status: Needs review » Needs work

The last submitted patch, 2: nodequeue_final-check-for-subqueue-in-rules.patch, failed testing.

fizk’s picture

fizk CreditAttribution: fizk commented
Status: Needs work » Needs review
shadysamir’s picture

shadysamir CreditAttribution: shadysamir as a volunteer commented

Added patch for first point in #2760029: Rules action does not respect hook_nodequeue_subqueues

shadysamir’s picture

shadysamir CreditAttribution: shadysamir as a volunteer commented
Title: Rules action does not respect all smartqueues » Rules action ignored taxonomy smartqueue

I am changing the title to match the specific issue addressed by the patch. The other issue is covered in #2760029: Rules action does not respect hook_nodequeue_subqueues

  • fizk committed 6a62d34 on 7.x-2.x authored by shadysamir 
    Issue #2760017 by shadysamir: Rules action ignored taxonomy smartqueue
fizk’s picture

fizk CreditAttribution: fizk commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.