Rules action does not respect hook_nodequeue_subqueues [#2760029]

Rules action only checks for smartqueue taxonomy module subqueues ignoring all other smartqueue modules, like smartqueue language. This patch will invoke the hook for all modules, including smartqueue taxonomy.

Comment	File	Size	Author
#2	nodequeue_respect-hook-subqueues-in-rules-action-2760029-2.patch	1.31 KB	shadysamir
#2	7.x-2.x: PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass PHP 7 & MySQL 5.5, D7 64 pass
	nodequeue_respect-hook-subqueues-in-rules-action.patch	1.29 KB	shadysamir

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 July 2016 at 22:22

shadysamir created an issue. See original summary.

Comment #2

shadysamir CreditAttribution: shadysamir as a volunteer commented 4 July 2016 at 08:06

Issue summary:

View changes

File	Size
nodequeue_respect-hook-subqueues-in-rules-action-2760029-2.patch	1.31 KB
7.x-2.x: PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass PHP 7 & MySQL 5.5, D7 64 pass

1 file was hidden/shown/deleted

File	Size
nodequeue_respect-hook-subqueues-in-rules-action.patch	1.29 KB

One should not submit patches when half asleep. Here is the patch again fixing an embarrassing mistake.

Comment #3

shadysamir CreditAttribution: shadysamir as a volunteer commented 4 July 2016 at 08:42

I tested #2 with smartqueue_language and it failed as module_invoke will pass arguments by value when the hook implementation is expecting it by reference. I can only think of ignoring module_invoke and implementing our own call_user_func_array.